[V3 Filter] implement exempting other users/roles from the filter #2064
Conversation
palmtree5
added
Type: Enhancement
redbot/cogs/filter/filter.py
Outdated
| word_list = await self.settings.guild(server).filter() | ||
| word_list = set( | ||
| await self.settings.guild(server).filter() | ||
| + self.settings.channel(message.channel).filter() |
There was a problem hiding this comment.
self.settings.channel(message.channel).filter() needs to be awaited.
There was a problem hiding this comment.
Aside from the co-routine needing to be awaited on line 363, I only have a few things.
When exempting a user or a role, you can simply type in the role name, but a user must be mentioned. It won't throw an error message in discord, but it will raise a BadUnionArgument in the console.
Finally, there isn't a way to remove the exempted users or roles.
Not sure if this would exceed the scope of the PR, but it would be nice if there was a way to view what roles/users have been exempted as well.
Redjumpman
added
QA: Changes Requested
|
Sorry to tack something else onto the above from RJM... After the discussion in the discord about adding a more global setting (instead of each cog including 3rd party needing these settings where applicable), #2129 once merged will add such a setting, It also includes adding logic to filter to handle interaction based on the current filter code, but this does somewhat obsolete (some of) this. I did add in filter immunity based on them in that PR, but am not sure how this interacts with the other planned changes your description alludes to. |
|
I've actually gone ahead and dropped the exemptions stuff in favor of the automated mod action immunity settings introduced in #2129 |
palmtree5
dismissed
Redjumpman’s stale review
Dropped exemptions in favor of the setting added
palmtree5
added
QA: Needed
and removed
QA: Changes Requested
Redjumpman
added
QA: Passed
Type
Description of the changes
Adds user/role exemptions for the filter. Will also be extending with channel-specific filters