[V2 General] fixed lmgtfy when search term contains a plus #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A plus in an equation is interpreted as a space by https://lmgtfy.com which breaks the equation. Fixed by escaping plus characters in the search terms.
|
Ran into this problem myself and this works to fix it, would recommend including for sure |
Tobotimus
changed the title
|
This fix does work, the same bug exists in the V3 version of lmgtfy. I'm going to open a PR for this in V3 too. |
3 tasks
Redjumpman
approved these changes
Aug 13, 2018
Kowlin
approved these changes
Aug 13, 2018
Tobotimus
approved these changes
Aug 13, 2018
|
Thanks for the patch @ToxicFrazzles, we're sorry it took so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A plus in an equation is interpreted as a space by https://lmgtfy.com which breaks the equation. Fixed by escaping plus characters in the search terms.
Type
Description of the changes
Before spaces are replaced with pluses replace pluses with "%2B" (the URL escaped plus) to allow search terms containing a plus such as equations to be properly processed by the web page linked to.