Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Core] More features for the bot invite URL #1847

Merged
merged 18 commits into from
Jun 3, 2019

Conversation

laggron42
Copy link
Contributor

@laggron42 laggron42 commented Jun 10, 2018

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This PR adds a new [p]inviteset group command that allows 3 things:

  • Make the [p]invite command available for everyone, so they can invite the bot without asking its owner. However, if the "Public bot" option is not ticked in the token settings, the command will block the action and tell the user to modify it.

  • Modify the permission level of the bot. The permission is given with the permission calculator (too complicated to use discord's method and iterate every permission) and it will be added to the bot's invite.

  • The ability to add a redirect URL. It will be added to the bot's invite too, and will redirect to a website when the bot is invited.

Warning

This PR is using a new feature that I made, which allows the bot to use the bot_public endpoint (to know if the "public bot" option is enabled or not). A PR is open on discord.py's repo, so please wait for it to be merged before merging this.

The PR : Rapptz/discord.py#1341

If you want to test that feature, do this in a virtualenv:

pip3 install -U --process-dependency-links git+https://github.com/retke/Red-DiscordBot@invite-additions
pip3 install -U git+https://github.com/retke/discord.py@patch-1
pip3 install yarl==0.18.0
pip3 install async-timeout==2.0.1

@palmtree5 palmtree5 added the V3 label Jun 10, 2018
@palmtree5 palmtree5 added this to the Beta 17 milestone Jun 10, 2018
@Tobotimus Tobotimus added the Blocked By: Other PR Blocked by another PR. label Jun 23, 2018
@Tobotimus Tobotimus removed this from the Beta 17 milestone Jun 23, 2018
@Tobotimus Tobotimus added QA: Unassigned Blocked By: Dependency Blocked by a package listed as a dependency. and removed QA: Needed Blocked By: Other PR Blocked by another PR. labels Aug 13, 2018
@laggron42
Copy link
Contributor Author

My pull request was just merged (actually rebased, but that's the same). This PR is not blocked anymore by discord.py.

redbot/core/core_commands.py Outdated Show resolved Hide resolved
@Kowlin
Copy link
Member

Kowlin commented Dec 13, 2018

Has conflict, please fix. Also, is the stuff in the rewrite branch of D.py yet?

@laggron42
Copy link
Contributor Author

@Kowlin yep, PR is rebased since august. I'll fix the conflicts.

@Kowlin Kowlin removed the Blocked By: Dependency Blocked by a package listed as a dependency. label Feb 8, 2019
redbot/core/core_commands.py Outdated Show resolved Hide resolved
redbot/core/core_commands.py Outdated Show resolved Hide resolved
@Tobotimus Tobotimus added the Type: Feature New feature or request. label Feb 22, 2019
@mikeshardmind mikeshardmind added this to the 3.1.3 milestone Jun 3, 2019
@mikeshardmind mikeshardmind merged commit 61b5730 into Cog-Creators:V3/develop Jun 3, 2019
laggron42 pushed a commit to laggron42/Laggrons-Dumb-Cogs that referenced this pull request Jun 18, 2019
This fixes the conflict introduced by Cog-Creators/Red-DiscordBot#1847

Merge of pull request #51 by @NeuroAssassin

* Change to roleinviteset

* Update to roleinviteset in docs

* Update to roleinviteset for readme

* I did a whoopsie
laggron42 pushed a commit to laggron42/Laggrons-Dumb-Cogs that referenced this pull request May 22, 2020
This fixes the conflict introduced by Cog-Creators/Red-DiscordBot#1847

Merge of pull request #51 by @NeuroAssassin

* Change to roleinviteset

* Update to roleinviteset in docs

* Update to roleinviteset for readme

* I did a whoopsie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants