[V3] Send meaningful responses on conversion failure #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobotimus
commented
Jun 7, 2018
| from concurrent.futures import ThreadPoolExecutor | ||
| from pathlib import Path | ||
| from subprocess import run as sp_run, PIPE | ||
| from sys import executable | ||
| from typing import Tuple, MutableMapping, Union | ||
|
|
||
| from discord.ext import commands | ||
|
|
||
| from redbot.core import Config |
There was a problem hiding this comment.
JSYK the Config import here was unused
There was a problem hiding this comment.
The commands import is used for type hinting, did you account for that?
There was a problem hiding this comment.
The commands import is replaced by from redbot.core import commands
Tobotimus
commented
Jun 7, 2018
| @@ -2,17 +2,13 @@ | |||
| import functools | |||
| import os | |||
| import pkgutil | |||
| import shutil | |||
There was a problem hiding this comment.
This import was unused
tekulvw
approved these changes
Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the bot can send a more meaningful message when converting an argument fails. Converters can do this by raising
commands.BadArgumentwith its first argument being the message they would like to send to the user.If a message isn't passed into the exception, the bot will simply send the help message. If the exception raised from the converter doesn't inherit from
commands.BadArgument, the command will error out as usual, so we don't suppress any bugs.Also note that this message will only be sent if the command is an instance of
redbot.core.commands.Command.P.S. sorry for so many changed files, but I went through and updated existing converters and also made sure all
discord.ext.commandsimports are actually nowredbot.core.commands, since this was sometimes causing issues and inconsistencies with this change.Resolves #967.