-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V3] Optimize the backup command #1666
Merged
Kowlin
merged 12 commits into
Cog-Creators:V3/develop
from
palmtree5:V3/enhancement/optimize_backup
May 28, 2018
Merged
[V3] Optimize the backup command #1666
Kowlin
merged 12 commits into
Cog-Creators:V3/develop
from
palmtree5:V3/enhancement/optimize_backup
May 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would it make sense for this to prompt to send it via DM if the archive size is under file size limitation for bots? (8mb) |
Oh, and another minor detail: you'll be able to specify a path for where to put the file (though the filename will remain in the same format) |
ok, this should be ready for testing at this point |
Kowlin
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
This optimizes the file generated when doing
[p]backup
to exclude:__pycache__
foldersRepoManager
'srepos
folderDownloader
'slib
folderCogManager
'scogs
folderHowever, this also generates a repo list that will be used in a separate, yet-to-be-written restore function and in conjunction with
Downloader
's settings (which contain the list of installed cogs) to allow reinstalling cogs when restoring.I still need to implement this into backups done from
redbot-setup
's functions though, so this is not ready for merge quite yet. I'll comment when I feel it's ready for merge