Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Optimize the backup command #1666

Merged

Conversation

palmtree5
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This optimizes the file generated when doing [p]backup to exclude:

  • The Lavalink jar file
  • All __pycache__ folders
  • RepoManager's repos folder
  • Downloader's lib folder
  • CogManager's cogs folder

However, this also generates a repo list that will be used in a separate, yet-to-be-written restore function and in conjunction with Downloader's settings (which contain the list of installed cogs) to allow reinstalling cogs when restoring.

I still need to implement this into backups done from redbot-setup's functions though, so this is not ready for merge quite yet. I'll comment when I feel it's ready for merge

@palmtree5 palmtree5 added the V3 label May 15, 2018
@palmtree5 palmtree5 added this to the Beta 15 milestone May 15, 2018
@palmtree5 palmtree5 requested a review from tekulvw as a code owner May 15, 2018 21:50
@mikeshardmind
Copy link
Contributor

Would it make sense for this to prompt to send it via DM if the archive size is under file size limitation for bots? (8mb)

@palmtree5
Copy link
Member Author

Oh, and another minor detail: you'll be able to specify a path for where to put the file (though the filename will remain in the same format)

@palmtree5 palmtree5 requested a review from Twentysix26 as a code owner May 15, 2018 22:42
@palmtree5
Copy link
Member Author

ok, this should be ready for testing at this point

@palmtree5 palmtree5 added Type: Enhancement Something meant to enhance existing Red features. needs testing labels May 16, 2018
@palmtree5 palmtree5 requested a review from Tobotimus May 16, 2018 01:30
@Kowlin Kowlin merged commit 7775b16 into Cog-Creators:V3/develop May 28, 2018
@palmtree5 palmtree5 deleted the V3/enhancement/optimize_backup branch May 31, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants