[V3] Code standards (black code format pass) #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeshardmind
requested review from
palmtree5,
tekulvw,
Tobotimus and
Twentysix26
as code owners
bobloy
reviewed
May 14, 2018
|
|
||
| @announce.command(name="ignore") | ||
| @commands.guild_only() | ||
| @checks.guildowner_or_permissions(administrator=True) | ||
| async def announce_ignore(self, ctx, *, guild: discord.Guild=None): | ||
| async def announce_ignore(self, ctx, *, guild: discord.Guild = None): |
There was a problem hiding this comment.
Why does it add spaces around the = operator here and not below?
| message: str, | ||
| config=None): | ||
|
|
||
| def __init__(self, ctx: commands.Context, message: str, config=None): |
There was a problem hiding this comment.
Here it does not add spaces around the = operator, despite doing it above frequently
There was a problem hiding this comment.
One of them has a type annotation and the other does not. It's consistent and compliant.
Aioxas
reviewed
May 14, 2018
|
|
||
| self.conf.register_guild( | ||
| announce_ignore=False, | ||
| announce_channel=None, # Integer ID | ||
| selfroles=[] # List of integer ID's | ||
| selfroles=[], # List of integer ID's |
There was a problem hiding this comment.
Where did this even come from. Is that compliant?
There was a problem hiding this comment.
Yes, it's compliant and a style choice.
tekulvw
previously approved these changes
May 14, 2018
tekulvw
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
ran black: code formatter against
redbot/with-l 99resulting code should be functionally equivalent via ast comparison
This works towards #1636 and the discussed goals in discord