Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Audio] Add voteskip and DJ role #1473

Merged
merged 8 commits into from
Apr 3, 2018
Merged

[V3 Audio] Add voteskip and DJ role #1473

merged 8 commits into from
Apr 3, 2018

Conversation

aikaterna
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Added vote skip and DJ Role setting to Audio.

Generally exempt users (hereafter referred to as “Mods”):
Red admins, Red mods, bot owner, bot co-owners, server owner, users with the DJ role (if active)

Default mode:
Everyone can play, search, stop, and use queue management commands (bump, prev, remove, etc).
Mods can manage the queue without being in the voice channel.
Disconnect is restricted to the Mods.

Voteskip mode:
Everyone can play, search, and use queue management commands.
Mods can manage the queue without being in the voice channel.
Plebs (non-generally exempt users) are prompted to vote to skip when using stop and cannot use disconnect when there are other users listening to music.
Plebs must vote to skip a song by using the skip command. This vote process ignores generally exempt users - they can skip immediately without voting.
Plebs are able to use restricted commands without restrictions when they are the only person listening.

DJ Role mode:
Most commands are restricted for use to only users with the admin-designated DJ role. Mods are exempt.
Plebs can use now, queue, and search but they will not have options to enqueue any songs or use any queue management commands.

DJ Role mode and Voteskip mode enabled:
Everything listed in the DJ Role section is true, except that users without the DJ role can now use voteskip to be able to skip songs.

Partially fixes #1478. Users will need to use pause twice before resuming until issue no. 20 on the Red-Lavalink repo is addressed.
Adds a price option for enqueuing songs. If DJ mode is active when jukebox mode is active, no one is charged credits as mods are exempt and plebs can't queue songs without the DJ role.
@tekulvw tekulvw merged commit d9c71bd into Cog-Creators:V3/develop Apr 3, 2018
@aikaterna aikaterna deleted the patch-4 branch April 4, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants