[V3 Config] Fix unloading and implement singleton driver #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on a couple of my cogs. This resolves my issue (#1457), although I encourage others to test this if you were experiencing the same thing. |
|
This pull request breaks the |
…iscordBot into V3/config/singleton_driver
|
The last commit fixed the previous bug I mentioned with the |
palmtree5
approved these changes
Apr 3, 2018
This was referenced Apr 3, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
There was a bug with the unload command that wouldn't allow unloaded cogs to be fully released. This PR fixes that issue (as seen in #1457) and implements the singleton driver referenced in #1406.