Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Issue 1363 #1424

Merged
merged 2 commits into from
Mar 12, 2018
Merged

[Bugfix] Issue 1363 #1424

merged 2 commits into from
Mar 12, 2018

Conversation

BaIthamel
Copy link
Contributor

@BaIthamel BaIthamel commented Mar 12, 2018

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

[p]cogs and [p]repo now print alphabetically

[p]cogs and [p]repo now print alphabetically
@BaIthamel BaIthamel requested a review from tekulvw as a code owner March 12, 2018 06:01
@BaIthamel BaIthamel changed the title Fix for Issue 1363 [Bugfix] Issue 1363 Mar 12, 2018
@tekulvw
Copy link
Member

tekulvw commented Mar 12, 2018

Why do you have key=str.lower in each of the sorted() calls? It seems unnecessary

@palmtree5 palmtree5 added the V3 label Mar 12, 2018
@BaIthamel
Copy link
Contributor Author

Without that entries with capitalised letters will sort together before lowercase entries.
eg.
(Alpha, Zulu , bravo) without it
(Alpha, bravo, Zulu) with it
It's more a just in case rather than needed.

@tekulvw tekulvw merged commit 1cb74f0 into Cog-Creators:V3/develop Mar 12, 2018
@tekulvw
Copy link
Member

tekulvw commented Mar 12, 2018

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants