[V3 Config] Adjust functionality of get_attr #1342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a BREAKING CHANGE
Type
Description of the changes
For a bit of background: get_attr has a resolve kwarg which changes how the method acts. If resolve is true, get_attr will return a coroutine which, when awaited, returns the actual saved value of that attribute. If resolve is false, get_attr returns the next nested group object
As an example:
And:
And:
This PR permanently removes the resolve kwarg from get_attr and keeps the functionality that occurs when resolve=False is passed currently.
set_attr
was also removed.This change was brought on by it's replacement by
set_raw
.