Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Warnings] [p]warnings dose not allow user mention #2403

Closed
CGDoctor8 opened this issue Feb 1, 2019 · 1 comment · Fixed by #2404
Closed

[Warnings] [p]warnings dose not allow user mention #2403

CGDoctor8 opened this issue Feb 1, 2019 · 1 comment · Fixed by #2404
Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Comments

@CGDoctor8
Copy link

CGDoctor8 commented Feb 1, 2019 •
edited
Loading

Command bugs

[p]warnings
[p]unwarn

What cog is this command from?

Warnings

What were you expecting to happen?

[p]warnings and [p]unwarn would allow user mention to see past warnings

What actually happened?

it only accepts user ID

How can we reproduce this issue?

Warn a user then check there warnings
EX:
$warn @CGDoctor8 Spam
$warnings @CGDoctro8
The following error will be given
Converting to "int" failed for parameter "userid".
@Kowlin Kowlin added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. V3 Status: Accepted We want this labels Feb 1, 2019
@Kowlin
Copy link
Member

Kowlin commented Feb 1, 2019

Can be most likely resolved with an typing.Optional.

palmtree5 pushed a commit that referenced this issue Feb 3, 2019
@palmtree5
Improve usability of warnings/unwarn\n resolves #2403 (#2404)
01ebf28
@Tobotimus Tobotimus removed the Status: Accepted We want this label Feb 15, 2019
Tobotimus pushed a commit that referenced this issue Feb 15, 2019
@Tobotimus
Improve usability of warnings/unwarn\n resolves #2403 (#2404)
644bb0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[V3] Improve usability of warnings/unwarn
3 participants
@Tobotimus @Kowlin @CGDoctor8