[V3 Filter] Unable to filter sentences

[Crossedfall]

Command bugs

Command name

filter add "<sentence>"

What cog is this command from?

Filter [core]

What were you expecting to happen?

Whenever the full sentence is posted within the filtered Discord server, it should be removed by the bot.

What actually happened?

Nothing. Sentences will be deleted if you remove the spaces from the trigger phrase, however.

How can we reproduce this issue?

1. Create a new filter with spaces
2. Attempt to trigger the filter

Note: it would seem that some sentences are read whereas most are not. Multiple tests are advised

Red Version

[mikeshardmind]

Unfortunately, that gif isn't a demonstration of anything not working.

The filter will never impact other bots, the bot owner, mods or admins:

Red-DiscordBot/redbot/cogs/filter/filter.py

Lines 248 to 251 in 3bcf375

	# Bots and mods or superior are ignored from the filter
	mod_or_superior = await is_mod_or_superior(self.bot, obj=author)
	if mod_or_superior:
	return

Red-DiscordBot/redbot/core/utils/mod.py

Lines 143 to 150 in 3bcf375

	if user and user == await bot.is_owner(user):
	return True
	elif admin_role and discord.utils.get(user.roles, name=admin_role):
	return True
	elif mod_role and discord.utils.get(user.roles, name=mod_role):
	return True
	else:
	return False

if you need to test filter's behavior, if you launch the bot with --dev you can use [p]mockmsg or you can get someone else to help you test it.

[Crossedfall]

@mikeshardmind if you watch the gif to the end you'll note that it filters the message if I remove all of the spaces. That'd imply that it does actually filter messages from a bot owner and guild admin.

If it really isn't supposed to do that, then there might be another issue at play, possibly unrelated to this report.

Edit: I have tested this with other users and in other servers. I can confirm that even without this oddity it still happens.

[mikeshardmind]

Does the audit log confirm it was your bot, and are you running more than one bot on that token?

If the answer to those is "yes" and "no" respectively, something is seriously wrong here.

[Crossedfall]

As far as I can tell, filtering words is not tracked in the log; even with the --debug flag. No other bots are running with this token.

I have done a number of tests on this and I can confirm without a shadow of a doubt that it will filter away my messages without a problem. Have you tested and had different results?

[mikeshardmind]

Well, something is seriously wrong.... I can confirm both the issue with the spacing and with the bot owner being considered for deletion.

[Crossedfall]

@mikeshardmind Update: In B17, I can confirm that the bot no longer removes owner messages. The filter is still broken unfortunately.

[palmtree5]

oh wait, I know exactly why bot owner messages are being considered for deletion

if user and user == await bot.is_owner(user): 
     return True

bot.is_owner returns a bool. Hence why bot owner messages are being considered for deletion. That's actually a really easy fix though as you really just need to drop user == from that.

The sentences issue results from the way it's added to the filter. Consider the following:

https://github.com/Cog-Creators/Red-DiscordBot/blob/V3/develop/redbot/cogs/filter/filter.py#L76-L87

Notice under the outermost else in the for loop here that no spaces are ever actually added back in when adding words in the sentence to tmp.

I'm gonna assign this to myself to do as both are simple fixes

[Tobotimus]

Resolved by #2065.