-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Feature/gh158 styling template #160
Open
nataliadiaz2
wants to merge
27
commits into
main
Choose a base branch
from
feature/gh158-styling-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admin Layouts style Avatar comp. add
Admin Layout Styling
Admin Teams Style Update
Admin form changes
Routes Update Teams user style change
- Removed LLC - Fixed casing on All Rights Reserved - Swapped out Social media icons for icon component
- removed the nav menu icon, made it out of divs and css - created a nav constants file to make it easier to sync mobile and desktop navigation Co-authored-by: Natalia Diaz <[email protected]>
Updated Affected Tests Updated Home Page Mobile Response
talk2MeGooseman
requested changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to run prettier fix and update tests to handle new layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Additional styles to Template
Analysis and Design
Analyze and attach design documentation.
Screenshots
Affected Areas
All pages of the template
Tests
Test update to reflect changes
Was this feature tested on all browsers?
Definition of Done
PR Comments Emoji Legend
😻 -
⚠️ -
:heart_cat_eyes:
Compliment to code/idea/etc♻️ -
:recycle:
Non-blocking proposed refactor➕ -
:heavy_plus_sign:
Non-blocking proposed addition🔥 -
:fire:
Non-blocking proposed removal❓ -
:question:
Non-blocking question:warning:
Blocking comment that must be addressed before PRGifs for life (required)