Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature/gh158 styling template #160

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

nataliadiaz2
Copy link
Collaborator

Pull Request

Description

Additional styles to Template

Analysis and Design

Analyze and attach design documentation.

Screenshots

Screenshot 2023-04-11 at 9 16 31 AM

Screenshot 2023-04-11 at 9 18 45 AM

Screenshot 2023-04-11 at 9 17 58 AM

Affected Areas

All pages of the template

Tests

Test update to reflect changes

Was this feature tested on all browsers?

  • Chrome
  • Firefox
  • Edge
  • Internet Explorer
  • Safari

Definition of Done

  • README updated
  • Tests written
  • Acceptance criteria implement
  • Code reviewed
  • Feature accepted

PR Comments Emoji Legend

😻 - :heart_cat_eyes: Compliment to code/idea/etc
♻️ - :recycle: Non-blocking proposed refactor
➕ - :heavy_plus_sign: Non-blocking proposed addition
🔥 - :fire: Non-blocking proposed removal
❓ - :question: Non-blocking question
⚠️ - :warning: Blocking comment that must be addressed before PR

Gifs for life (required)

mandatory

Copy link
Contributor

@talk2MeGooseman talk2MeGooseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to run prettier fix and update tests to handle new layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants