Eliminate the need to import specHelper everywhere #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the [issue I opened on mocha-webpack](zinserjan/mocha-webpack#1) is still outstanding, the author’s suggestion is to use `webpack-node-externals`. We tried that initially, but that results in numerous firings of the `import/no-unresolved` lint rule. After conferring with @lexun, we decided to go back to that approach and instead disable the linters when doing `npm run test`. They still run with `npm run build`, `npm run test:debug`, and `npm run dev`. If the above-mentioned issue gets resolved, then we can go back to running the linters in all environments.
|
LGTM |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the issue I opened on mocha-webpack is
still outstanding, the author’s suggestion is to use
webpack-node-externals. We tried that initially, but that results in numerous firings of theimport/no-unresolvedlint rule.After conferring with @lexun, we decided to go back to that approach and instead disable the linters when doing
npm run test. They still run withnpm run build,npm run test:debug, andnpm run dev.If the above-mentioned issue gets resolved, then we can go back to running the linters in all environments.