refactor(android): separate messages for signin exception #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reslear Could you maybe add this PR to your fork? Thank you! |
|
and for iOS same? |
|
@reslear I added the iOS status code. The cordova-plugin-googleplus does not include it. As the status codes are different for iOS and Android, the user of the plugin has to check the platform and then check for the respective error code:
In the future we could provide a custom enum to unify this maybe. |
reslear
changed the title
reslear
pushed a commit
to reslear/CapacitorGoogleAuth
that referenced
this pull request
Feb 1, 2022
…udio#176) * added status code for android implementation * added iOS error code Co-authored-by: Philipp Heuer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to properly react to the situation where a user cancels the flow, I added the status code to the Android implementation. The iOS returns the same message in case the user cancels the flow:
"The user canceled the sign-in flow."For me this is the last step in order to make this plugin a full replacement for the cordova-plugin-googleplus which also returns the status code.