-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ios to GoogleSignIn 6.0.1 Pod #136
Conversation
hi @joeflateau wow! cool, this same #133 ?) |
hi, @reslear yeah i didn't see your PR before but I needed to run an app w/ Google Sign In in a sim on my mac so I did what I needed to do |
ok, i'm close my draft :) good job 💪 |
hi @joeflateau i'm ready to merge pr, but need to fix the 3 warnings, could you do it? |
@reslear yes I'll do it right now |
@reslear should be good to go here |
@joeflateau thx :) test before merge |
@reslear what's the management structure for this plugin? are you building a fork or is that just testing and you are maintaining this one now? |
@joeflateau this is fork for testing and experiments with open pr, now = origin master + #134 + you #136 |
#134 breaks iOS for me. init can't be used as an identifier like that |
temp solution use
|
i didn't know you could escape identifiers like that, my solution was: #134 (comment) |
How is best solution? (I'm just junior in swift 😃 ) |
I'd use your solution instead, escape with backticks. avoid objc renaming |
Could explain why it breaks? |
breaks because however
works because you've escaped the my solution would also work, but will likely be more painful to maintain than yours
|
@joeflateau Now it's clear thanks |
@joeflateau What are the test results and which framework used? |
@reslear no test framework or results for swift, just ran the app and logged in with google |
docs: add information about `Client ID`
fix: any conflicts
Before v6 you could not run an app using GoogleSignIn on a Simulator on an M1/Apple Silicon Mac.