Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ios to GoogleSignIn 6.0.1 Pod #136

Merged
merged 13 commits into from
Aug 27, 2021

Conversation

joeflateau
Copy link
Contributor

Before v6 you could not run an app using GoogleSignIn on a Simulator on an M1/Apple Silicon Mac.

@joeflateau
Copy link
Contributor Author

see firebase/firebase-ios-sdk#7208

@reslear
Copy link
Collaborator

reslear commented Aug 16, 2021

hi @joeflateau wow! cool, this same #133 ?)

@joeflateau
Copy link
Contributor Author

hi, @reslear yeah i didn't see your PR before but I needed to run an app w/ Google Sign In in a sim on my mac so I did what I needed to do

@reslear
Copy link
Collaborator

reslear commented Aug 16, 2021

ok, i'm close my draft :) good job 💪

@reslear
Copy link
Collaborator

reslear commented Aug 24, 2021

hi @joeflateau i'm ready to merge pr, but need to fix the 3 warnings, could you do it?

Screenshot 2021-08-24 at 17 20 14

Screenshot 2021-08-24 at 17 20 28

Screenshot 2021-08-24 at 17 20 39

@joeflateau
Copy link
Contributor Author

@reslear yes I'll do it right now

@joeflateau
Copy link
Contributor Author

@reslear should be good to go here

@reslear
Copy link
Collaborator

reslear commented Aug 24, 2021

@joeflateau
Copy link
Contributor Author

@reslear what's the management structure for this plugin? are you building a fork or is that just testing and you are maintaining this one now?

@reslear
Copy link
Collaborator

reslear commented Aug 24, 2021

@joeflateau this is fork for testing and experiments with open pr, now = origin master + #134 + you #136

@joeflateau
Copy link
Contributor Author

#134 breaks iOS for me. init can't be used as an identifier like that

@reslear
Copy link
Collaborator

reslear commented Aug 24, 2021

temp solution use

func `init`(_ call: CAPPluginCall) {

@joeflateau
Copy link
Contributor Author

i didn't know you could escape identifiers like that, my solution was: #134 (comment)

@reslear
Copy link
Collaborator

reslear commented Aug 24, 2021

How is best solution? (I'm just junior in swift 😃 )

@joeflateau
Copy link
Contributor Author

I'd use your solution instead, escape with backticks. avoid objc renaming

@reslear
Copy link
Collaborator

reslear commented Aug 24, 2021

Could explain why it breaks?

@joeflateau
Copy link
Contributor Author

    func init(_ call: CAPPluginCall) {
        call.unimplemented("Not available on iOS")
    }

breaks because init cannot be used as an identifier this way because init is a special method in swift (it's basically a constructor)

however

    func `init`(_ call: CAPPluginCall) {
        call.unimplemented("Not available on iOS")
    }

works because you've escaped the init method name (https://docs.swift.org/swift-book/ReferenceManual/LexicalStructure.html)

my solution would also work, but will likely be more painful to maintain than yours

    @objc(init:)
    func initSwift(_ call: CAPPluginCall) {
        call.unimplemented("Not available on iOS")
    }

@reslear
Copy link
Collaborator

reslear commented Aug 24, 2021

@joeflateau Now it's clear thanks

@reslear
Copy link
Collaborator

reslear commented Aug 24, 2021

@joeflateau What are the test results and which framework used?

@joeflateau
Copy link
Contributor Author

@reslear no test framework or results for swift, just ran the app and logged in with google

@reslear reslear merged commit 4859f9c into CodetrixStudio:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants