fix: ingest job doesn't properly validate chunkDataSize causing it …

…to exceeds the API limit
Codeneos · Dec 28, 2023 · 074dfe2 · 074dfe2
1 parent 48db006
commit 074dfe2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/salesforce/src/bulk/bulkIngestJob.ts b/packages/salesforce/src/bulk/bulkIngestJob.ts
@@ -276,14 +276,16 @@ export class BulkIngestJob<TRecord extends object = any> extends BulkJob<IngestJ
         for (const item of data) {
             const row = columns.map(c => this.encodeValue(item[c])).join(this.delimiterCharacter) + this.lineEndingCharacters;
             const encodedRow = Buffer.from(row, this.encoding);
-            encodedData.push(encodedRow);
 
-            if (encodedDataSize + encodedRow.byteLength > this.chunkDataSize) {
+            if (encodedData.length > 1 && (encodedDataSize + encodedRow.byteLength) > this.chunkDataSize) {
                 const chunk = Buffer.concat(encodedData);
                 encodedData = [ encodedHeader ];
                 encodedDataSize = encodedHeader.byteLength;
                 yield chunk;
             }
+
+            encodedData.push(encodedRow);
+            encodedDataSize += encodedRow.byteLength;
         }
 
         if (encodedData.length > 1) {