Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to chakra #73

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Migrate to chakra #73

wants to merge 49 commits into from

Conversation

a-saran
Copy link
Contributor

@a-saran a-saran commented Jun 2, 2020

No description provided.

@a-saran a-saran added the WIP work in progress label Jun 2, 2020
@sanandnarayan
Copy link
Member

@a-saran kindly let me know when this is done and ready for review.

@sanandnarayan
Copy link
Member

@a-saran you will also need to write docs for your components. explain what they do .
I added an example doc in the latest commit in this PR for component button.

Use command yarn docz:dev

When you write docs you will understand why you need those components.

@sanandnarayan
Copy link
Member

please use the design system with taste and right levels of abstraction. if you are spilling out too many props you probably need a well named component

@sanandnarayan
Copy link
Member

@kalidasm can you review this ?

height={'1px'}
bg={'black.3'}
/>
)
}
</div>
))}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Mobile View is not responsive.
  2. Headers are not looking as intended

Seems styles are missing in /blog Page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, blog pages are loading from @codebrahma/gatsby-theme-blog package, theme is hardcoded in that package. I am working on it

@kalidasmuthusamy kalidasmuthusamy removed their assignment Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants