New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double emails on IDMTY confirmation #147

Closed

basicavisual opened this issue Nov 3, 2023 · 0 comments · Fixed by #148

Member

basicavisual commented Nov 3, 2023 •

edited

Loading

As a user, if I login via IDMty, I get a decidim confirmation email.

Expected behavior: Since I am using an externally validated account, I should not need to re-confirm my email. As stated here.

Other notes: After logging in with IDMty for the first time, I get this screen, which does not happen with other auth providers:

ghost pushed a commit that referenced this issue


          omniauth: prevent sending a verification email

f60ceea

`omniauth_registrations_controller.rb` fails to create an account when
the provider doesn't include a required field. This results in the form
being re-rendered leading to a second `#create` call and the creation of
a new `request.env`, causing the loss of data populated by OAuth and
triggering an email confirmation.

See: https://github.com/decidim/decidim/blob/release/0.26-stable/decidim-core/app/commands/decidim/create_omniauth_registration.rb#L75

This patch relies on the `params` to get the `verified_email`.

Closes: #147

ghost mentioned this issue

omniauth: prevent sending a verification email #148

Merged

basicavisual closed this as completed in #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment