Validation APIs: GradingJobConfig and GradingScript #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williams-jack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/Problem Description
Clients who use Orca should be able to check if a grading job configuration they've generated is valid; this can be accomplished by way of exposing a validation endpoint. This is the same case for the
GradingScriptcomponent of the job, where custom graders may need to validate that in isolation.Solution (Changes Made)
/api/v1/validate_grading_jobendpoint added to check request body againstGradingJobConfigvalidator./api/v1/validate_grading_scriptendpoint added to check request body against the newGradingScriptvalidator.Additional Notes
/route mapper was using Express'usefunction, it would take any route of the form/.*and any method (e.g., POST, GET, etc) and return the Orca API landing page if a route was given that did not exist. This is fixed by mapping it togetspecifically.