refactor: consolidate f strings for sha file and images url #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blerner
requested changes
Aug 22, 2024
There was a problem hiding this comment.
I think you've picked slightly the wrong abstraction-boundary. In the image_loading.py file, it doesn't care that the dockerfile you're looking for has a sha-based name. All it should do is care that "if you give me whatever you think is a unique name, I'll handle the details of looking for and downloading the corresponding .tgz file, and looking for and loading the corresponding image
worker/orca_grader/tests/docker_images/test_docker_image_loading.py
Outdated
Show resolved
Hide resolved
…extra formatting for file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/Problem Description
Passing around a grader image's SHA Sum (for downloading and checking against local file system) was unclear and redundant when calling the
retrieve_image_tgz_from_urlfunction. This PR seeks to consolidate that logic.Solution (Changes Made)