Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user resizing of sidebar #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow user resizing of sidebar #64

wants to merge 1 commit into from

Conversation

kylesferrazza
Copy link
Collaborator

closes #63

@kylesferrazza kylesferrazza marked this pull request as draft May 12, 2020 19:38
@kylesferrazza kylesferrazza marked this pull request as ready for review May 12, 2020 19:51
@kylesferrazza kylesferrazza requested a review from blerner May 12, 2020 19:52
@kylesferrazza kylesferrazza linked an issue May 12, 2020 that may be closed by this pull request
Allow resizing sidebar #63
Open
@kylesferrazza kylesferrazza force-pushed the fix-63 branch 2 times, most recently from e4bb2e6 to 6e77f9b Compare May 12, 2020 20:07
@kylesferrazza kylesferrazza changed the base branch from fix-58 to master May 12, 2020 20:14
@kylesferrazza kylesferrazza requested review from blerner and removed request for blerner June 12, 2020 16:19
@blerner
Copy link
Contributor

blerner commented Jun 12, 2020

This seems to work reasonably well, though the resize handle is awkward: ugly on Fx, and tiny on Chrome :( I'm torn on this for now...

@blerner
Copy link
Contributor

blerner commented Jun 12, 2020

also, worth rebasing this on the latest master, so it's less of a regression when we test it out...

@blerner
Copy link
Contributor

blerner commented Jun 15, 2020

I think we're going to want to use something like https://zesik.com/react-splitter-layout/ or a translated version of https://github.com/jquery/jquery-ui/blob/master/ui/widgets/resizable.js, instead of the tiny native resizer widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blerner blerner Awaiting requested review from blerner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow resizing sidebar
2 participants
@kylesferrazza @blerner