Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15] social media component #92

Merged
merged 4 commits into from
Jun 26, 2019
Merged

[15] social media component #92

merged 4 commits into from
Jun 26, 2019

Conversation

Loczi94
Copy link
Contributor

@Loczi94 Loczi94 commented Jun 5, 2019

No description provided.

OtisRed
OtisRed requested changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@OtisRed OtisRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking it from Windows so I didn't check the code yet, but I left you some comments regarding the structure of vue component (which we have agreed to apply lately) and the link to Slack.

frontend/src/components/SocialMedia.vue Show resolved Hide resolved
frontend/src/components/SocialMedia.vue
{
icon: 'fab fa-facebook-f',
link: 'https://www.facebook.com/CodeForPL/',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously there was also gitter icon here and as we discussed last week since we don't use we shall skip it then. But we also found out that there is an easy way to open the Slack workspace so you might add the icon for Slack and referenced it with this link: https://join.slack.com/t/codeforpoznan/shared_invite/enQtNjQ5MTU1MDI0NDA0LWJmMmM2NjI0MGNiZjJjMGM0NzMzOTEzOGY5YWZkZWNiMzZlZTM2ZGJlYzRkYTlmZTFlMTMzZjJkZTc5YjhhYjg (or some shortened version of it)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll do it :)

frontend/src/components/SocialMedia.vue Show resolved Hide resolved
OtisRed
OtisRed approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@OtisRed OtisRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did run it and it works all right. Looks nice as well.

@OtisRed OtisRed merged commit c227e1f into CodeForPoznan:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgajzlerowicz adamgajzlerowicz adamgajzlerowicz approved these changes

@OtisRed OtisRed OtisRed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Loczi94 @adamgajzlerowicz @OtisRed