Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UTs set-up and first test #445

Merged
merged 1 commit into from
Jan 26, 2022
Merged

UTs set-up and first test #445

merged 1 commit into from
Jan 26, 2022

Conversation

Marce1ina
Copy link
Contributor

@Marce1ina Marce1ina commented Sep 29, 2021 •
edited
Loading

Story / Bug id:

#436

Description:

  • Refactor of tree structure under frontend/src/components
  • Setup for frontend unit tests with Jest
  • Unit tests for rendering of all frontend components
  • Detailed sample unit tests for SocialMedia and ParticipantsChart components as well as helpers.spec.js

Migrations:

N/A

New imports / dependencies:

  • eslint-plugin-jest
  • @vue/cli-plugin-unit-jest
  • @vue/test-utils

What tests do I need to run to validate this change:

  • Visual regression of entire app (high-level is enough as only paths to files might be broken, so any errors should be visible right away).
  • Running npm test on local machine on master branch after the merge. Checking that unit tests are running and passing.

@Marce1ina
Copy link
Contributor Author

Marce1ina commented Sep 29, 2021 •
edited
Loading

TODO:

  • Check for regression after refactor (styles)
  • Complete all commented tests
  • Ad some functional tests
  • Add UT check in pipeline

@Marce1ina Marce1ina changed the title [WIP] UTs set-up and first test UTs set-up and first test Oct 13, 2021
arturtamborski
arturtamborski approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@arturtamborski arturtamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

OtisRed
OtisRed approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@OtisRed OtisRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marry Christmas!

@Marce1ina Marce1ina force-pushed the front-end-test-set-up branch from d0fa099 to 7f98aeb Compare January 5, 2022 20:41
@Marce1ina Marce1ina force-pushed the front-end-test-set-up branch from 7f98aeb to 77b8ac0 Compare January 26, 2022 18:51
@OtisRed OtisRed merged commit cb3ea6a into CodeForPoznan:master Jan 26, 2022
@Marce1ina Marce1ina deleted the front-end-test-set-up branch January 26, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturtamborski arturtamborski arturtamborski approved these changes

@OtisRed OtisRed OtisRed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marce1ina @arturtamborski @OtisRed