Added delete buttons for hacknight participants #417
Conversation
|
We don't. |
| @@ -65,6 +65,7 @@ | |||
| <v-icon>mdi-account-outline</v-icon> | |||
| </v-list-item-avatar> | |||
| <v-list-item-title v-text="item.github"></v-list-item-title> | |||
| <v-btn v-on:click="onDeleteParticipant(item)">Delete</v-btn> | |||
There was a problem hiding this comment.
Could we consider sth more graphically aesthetic than DELETE? :D We have font awsome oboard (e.g. see the exit button in ModalContent.vue) so we could use sth like these:
There was a problem hiding this comment.
Could we consider sth more graphically aesthetic than DELETE? :D We have font awsome oboard (e.g. see the exit button in
ModalContent.vue) so we could use sth like these:* https://fontawesome.com/v5.15/icons/user-times?style=solid * https://fontawesome.com/v5.15/icons/backspace?style=solid
@OtisRed agreed - these DELETE button is kind of a psycho :D
| @@ -89,6 +90,11 @@ export default { | |||
| this.$store | |||
| .dispatch('hacknight/addParticipants', ids) | |||
| .then(() => (this.selectedParticipants = [])); | |||
| }, | |||
| onDeleteParticipant(participant) { | |||
| const ids = [participant.id]; | |||
There was a problem hiding this comment.
You probably mirrored the solution for adding the participants. However @stanislawK used there ids in plural because there are many participants that can be added at once, but only one that can be deleted at a time given this solution we agreed upon. So please use sth like participant_id in singular form to name the variable and keep it consistent as you pass it to Vuex so that no one has to wonder if this is the same thing under the different names :D
| @@ -76,6 +76,20 @@ export default { | |||
| .catch(error => { | |||
| commit('raiseError', error); | |||
| }); | |||
| }, | |||
| deleteParticipants({ commit, getters }, participants_ids) { | |||
There was a problem hiding this comment.
ditto => deleteParticipant in singular
| onDeleteParticipant(participant) { | ||
| const ids = [participant.id]; | ||
|
|
||
| this.$store.dispatch('hacknight/deleteParticipants', ids); |
| axios | ||
| .delete(`/api/hacknights/${getters.getHacknight.id}/participants/`, { | ||
| data: { | ||
| participants_ids: participants_ids |
There was a problem hiding this comment.
ditto => participant_id: participant_id
| @@ -65,6 +65,9 @@ | |||
| <v-icon>mdi-account-outline</v-icon> | |||
| </v-list-item-avatar> | |||
| <v-list-item-title v-text="item.github"></v-list-item-title> | |||
| <v-btn v-on:click="onDeleteParticipant(item)"> | |||
There was a problem hiding this comment.
How would you like this?
| <v-btn v-on:click="onDeleteParticipant(item)"> | |
| <v-btn icon v-on:click="onDeleteParticipant(item)"> |
| @@ -65,6 +65,9 @@ | |||
| <v-icon>mdi-account-outline</v-icon> | |||
| </v-list-item-avatar> | |||
| <v-list-item-title v-text="item.github"></v-list-item-title> | |||
| <v-btn v-on:click="onDeleteParticipant(item)"> | |||
| <i class="fas fa-user-times fa-lg"></i> | |||
There was a problem hiding this comment.
Maybe we could also use red color to communicate deleteing function?
| <i class="fas fa-user-times fa-lg"></i> | |
| <i class="button_delete fas fa-user-times fa-lg"></i> |
Then we could add new class:
.button_delete {
color: $red;
}
And add global red (e.g. #ed130c) in scss/colors.scss so it can parse it from a global source :)
|
Also - you got conflicts :P |
backend/resources/hacknight.py
Outdated
| @@ -91,13 +91,13 @@ def delete(self, id): | |||
| hacknight = Hacknight.query.get_or_404(id) | |||
| participants = {participant.id for participant in hacknight.participants} | |||
| json_data = request.get_json(force=True) | |||
| ids_schema = Schema.from_dict({"participants_ids": fields.List(fields.Int())}) | |||
| ids_schema = Schema.from_dict({"participant_id": fields.List(fields.Int())}) | |||
There was a problem hiding this comment.
We should either change participants_ids -> participant_id in corresponding unit tests, or stick with plural (which would be more consistent since in post participants_ids left)
jacekkalbarczyk
force-pushed
the
364_Delete_participant_from_hacknight
branch
from
f8918c5 to
fe283d1
Compare
jacekkalbarczyk
force-pushed
the
364_Delete_participant_from_hacknight
branch
from
d17739e to
cc75c54
Compare
Story / Bug id:
#364
Description:
Added buttons enabling removing participants from hacknight at HacknightsParticipants component.
Migrations:
N/A
New imports / dependencies:
N/A
What tests do I need to run to validate this change:
N/A