Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[35] login component #40

Merged
merged 4 commits into from
Apr 3, 2019

Conversation

stanislawK
Copy link
Contributor

No description provided.

Copy link
Contributor

@adamgajzlerowicz adamgajzlerowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on adding translations? There are already quite a few strings and it would be nice to start adding translations early

components: {
HelloWorld
}
components: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

return {
username: '',
password: '',
show1: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why show1?

show1: false,
error_msg: '',
successAlert: false,
spinner: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showSpinner

@stanislawK stanislawK merged commit 1f31ba3 into CodeForPoznan:master Apr 3, 2019
@stanislawK stanislawK deleted the 35_login_component branch April 3, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants