-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[35] login component #40
[35] login component #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning on adding translations? There are already quite a few strings and it would be nice to start adding translations early
frontend/src/App.vue
Outdated
components: { | ||
HelloWorld | ||
} | ||
components: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove
frontend/src/components/Login.vue
Outdated
return { | ||
username: '', | ||
password: '', | ||
show1: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why show1
?
frontend/src/components/Login.vue
Outdated
show1: false, | ||
error_msg: '', | ||
successAlert: false, | ||
spinner: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
showSpinner
No description provided.