Change validation rules in new participant form

[Marce1ina]

Story / Bug id:

#309

Description:

In new participant form:

• removed characters type validation for "First name" and "Last name",
• created custom validators for "GitHub username" and "Slack nick".

Migrations:

N/A

New imports / dependencies:

N/A

What tests do I need to run to validate this change:

Manual check of front-end form validation as follows:

• "First name" should accept any character,
• "Last name" should accept any charater,
• "Github username" should accept latin alphabet letters, as well as numbers and -, with the constraint that username cannot start or end with -,
• "Slack nick" should accept latin alphabet letters, as well as polish diacritical characters żźćńółęąś, numbers and ,.';-_/()[]{}.

[OtisRed]

I pulled the brunch, tried to spoil it, but it seems to work well. From my point of view it solves all the problems mentioned in the task so I leave approve but I would love for sb (@w1stler, @stanislawK, @jacekkalbarczyk, @kristhina) more fluent with regex to check the two experssions in custom validators at the bottom - before we merge it.

[OtisRed]

That's a neat trick to get around it - kudos!

[OtisRed]

I hate to be THAT guy but I would use: ąćęłńóśźżĄĆĘŁŃÓŚŹŻ - just for the sake of my OCD (and readability).

[Marce1ina]

Done

[stanislawK]

Whenever You want match the character - literally with regex, it is safer to escape it and use "\-" instead of "-".

[Marce1ina]

@stanislawK I have removed it as it causes lint failure: error: Unnecessary escape character: \- (no-useless-escape) at src/helpers/validation.js:10:26 and it seems fair, please check https://stackoverflow.com/questions/9589074/regex-should-hyphens-be-escaped for reference.