[26]tests for models and db #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stanislawK ping me when conflicts are resolved for testing |
w1stler
approved these changes
May 16, 2019
backend/tests/conftest.py
Outdated
|
|
||
| @pytest.fixture | ||
| def _db(): | ||
| """Create and configure a new db instance for pytest-flask-sqlalchemy""" |
backend/tests/test_db.py
Outdated
| """ | ||
| GIVEN mocked db session, and user data | ||
| WHEN a new user added to db | ||
| THEN check the user data from db |
There was a problem hiding this comment.
Gherkin syntax is descriptive and used for the BDD approach. I would stick with classic docstring convention. Though we can discuss this matter.
w1stler
reviewed
May 22, 2019
backend/tests/conftest.py
Outdated
| participant = {'name': 'Jon', | ||
| 'lastname': 'Doe', | ||
| 'email': '[email protected]', | ||
| 'phone': '123456789'} |
w1stler
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run tests: