[17]add contact us endpoint #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stanislawK ping me when conflicts are resolved so it could be tested properly. I think if we merge it first then it would be easier to double check frontend. |
It could cause migration conflicts
jacekkalbarczyk
approved these changes
Apr 10, 2019
OtisRed
approved these changes
Apr 14, 2019
There was a problem hiding this comment.
I tested it, using the front from #34 because I couldn't write a proper json request in Postman ^^ Anyway it works well with the frontend and returns nice 200. But I didn't tested validation on the backend side so I just trust @jacekkalbarczyk that they work there as well (on the front they work just all right). I looked through the code and it looks good to me.
As soon as the conflict is resolved and the typo in the title of this ticket corrected we are ready to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.