Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[96] Endpoint for removing participants from hacknight #285

Conversation

stanislawK
Copy link
Contributor

@stanislawK stanislawK commented Jun 17, 2020

Story / Bug id:

96

Description:

Endpoint for removing participants from hacknight

Migrations:

N/A

New imports / dependencies:

N/A

What tests do I need to run to validate this change:

Populate database.
Login with postman.
Check participants ids for hacknight: [GET] http://localhost:5000/hacknights/1/
Remove some participants:
[DELETE] http://localhost:5000/hacknights/1/participants/ with body:

{
    "participants_ids": [selected_id_one, selected_id_two, ...]
}

Check whether participants were removed correctly: [GET] http://localhost:5000/hacknights/1/participants/

@w1stler
Copy link
Member

w1stler commented Jul 1, 2020

Mismatch in description - we do DEL on http://localhost:5000/hacknights/1/participants/ ;-)

Copy link
Member

@w1stler w1stler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, aside from that looks fine!

def test_remove_all_participants_from_hacknight(
auth_client, add_participants_to_hacknight
):
"""Test remove all participant from hacknight."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test remove all participants from hacknight.

@OtisRed OtisRed merged commit 09b47ff into CodeForPoznan:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants