Added navigation guard for Dashboard component (fixes #231) #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maciek246
reviewed
Jan 8, 2020
frontend/src/router.js
Outdated
| @@ -4,13 +4,21 @@ import VueRouter from 'vue-router'; | |||
| import HomePage from './components/HomePage.vue'; | |||
| import Login from './components/Login.vue'; | |||
| import Dashboard from './components/Dashboard.vue'; | |||
| import store from './store/index'; | |||
There was a problem hiding this comment.
If this is only one 'index.js' file in this directory, JS should look for by default:
Suggested change
| import store from './store/index'; | |
| import store from './store'; |
Please verify that 👆
Maciek246
approved these changes
Jan 8, 2020
w1stler
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try go to http://localhost:8080/dasboard. You should be redirected to /login path.
Populate database with command make populate_database.
Login on http://localhost:8080/login with username from terminal output after populating db, and default password: pass123.
Then navigate to http://localhost:8080/dasboard