Adjusting to mobile view (fixes #223) #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtisRed
changed the title
Bosmanfrx
reviewed
Dec 11, 2019
| @@ -0,0 +1,2 @@ | |||
| $phone: 600px; | |||
There was a problem hiding this comment.
where did You get these breakpoints from?
There was a problem hiding this comment.
I modeled them after: https://vuetifyjs.com/en/customization/breakpoints
Do you @Bosmanfrx have better suggestion how to define breakpoints?
There was a problem hiding this comment.
I was just curious. ;) There is no one set of breakpoints. Maybe we could create map of all breakpoints here?
Bosmanfrx
approved these changes
Dec 11, 2019
stanislawK
approved these changes
Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces media query in scss that renders classes conditionally depending on the kind of screen that is being used.
How to test it