create edit participant endpoint (fixes #61) #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristhina
changed the title
|
Status code changed to 200 |
w1stler
requested changes
Nov 20, 2019
backend/resources/participant.py
Outdated
| db.session.add(participant) | ||
| db.session.commit() | ||
| return {"participant": participant_schema.dump(participant)}, HTTPStatus.OK |
backend/resources/participant.py
Outdated
| @@ -26,7 +28,7 @@ def post(self): | |||
| json_data = request.get_json(force=True) | |||
| if not json_data: | |||
| return {'message': 'No input data provided'}, \ | |||
| HTTPStatus.BAD_REQUEST | |||
| HTTPStatus.BAD_REQUEST | |||
magul
previously requested changes
Nov 28, 2019
There was a problem hiding this comment.
@kristhina pull request overall looks pretty solid, but I have few questions regarding the architecture of the application that would be great to have resolved before moving forward here.
Can you @stanislawK @jacekkalbarczyk @OtisRed and @w1stler dig into these questions and we will try to answer them at the next hacknight?
w1stler
approved these changes
Dec 11, 2019
|
@magul please refer to the changes that has been made |
OtisRed
pushed a commit
to OtisRed/codeforpoznan.pl_v3
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
send "put" request to "participants/1/":
Headers: Authorization: Bearer access_token; Content-Type: application/json
Body:
{
"first_name" : "janusz007",
"github": "januszek2"
}