Added tests for delete participant endpoint (fixes #193) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stanislawK
commented
Oct 30, 2019
stanislawK
commented
- make start
- make test
magul
changed the title
|
Can you, @stanislawK, merge back |
w1stler
reviewed
Nov 27, 2019
| ): | ||
| """Test get detais of non-existent participant""" | ||
| rv = client.get( | ||
| """Test get and delete non-existent participant""" |
| """Test get participant details for not logged in user.""" | ||
| @pytest.mark.parametrize("method", ["get", "delete"]) | ||
| def test_get_delete_participant_unauthorized(client, add_participants, method): | ||
| """Test get and delete participant with not logged in user.""" |
There was a problem hiding this comment.
I would remove get from all the scenarios and ensure that we have explicit one for testing get method. Others will be eg.: "Test delete participant when user logged-in / logged-out".
There was a problem hiding this comment.
I think it would make tests less readable, especially if we would merge #191. Following magul suggesion I introduced there logged in client fixture. So e.g. for testing get method I will have to inject two different test clients, which could be confussing.
kristhina
approved these changes
Dec 4, 2019
w1stler
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.