Add participants to hacknight endpoint with tests (fixes #93)

backend/app.py

@@ -7,7 +7,7 @@
     UserLogin, UserLogout, RefreshAccessToken, RevokeRefreshToken
 )
 from backend.resources.contact import SendMessage
-from backend.resources.hacknight import HacknightList, HacknightDetails
+from backend.resources.hacknight import HacknightDetails, HacknightList
 from backend.resources.participant import ParticipantDetails, ParticipantsList
 
 

backend/resources/hacknight.py

@@ -8,8 +8,9 @@
 from marshmallow import ValidationError
 
 from backend.extensions import db
-from backend.models import Hacknight
+from backend.models import Hacknight, Participant
 from backend.serializers.hacknight_serializer import HacknightSchema
+from backend.serializers.participant_serializer import ParticipantSchema
 
 
 class HacknightList(Resource):
@@ -53,3 +54,36 @@ def get(self, id):
         return {'hacknights': hacknight_schema.dump(Hacknight.query.get_or_404(
             id))
         }, HTTPStatus.OK
+
+    @jwt_required
+    def patch(self, id):
+        hacknight = Hacknight.query.get_or_404(id)
+        participants = [
+            participant.id for participant in hacknight.participants
+        ]
+
+        json_data = request.get_json(force=True)
+        ids_schema = ParticipantSchema(only=('participants_ids',))
+        try:
+            data = ids_schema.load(json_data)
+        except ValidationError as err:
+            return (err.messages), HTTPStatus.BAD_REQUEST
+
+        new_participants = [
+            id for id in data['participants_ids'] if id not in participants
+        ]
+
+        if not new_participants:
+            return {'message': 'No new participant has been provided'}, \
+                HTTPStatus.BAD_REQUEST
+
+        for new_participant in new_participants:
+            hacknight.participants.append(
+                Participant.query.get_or_404(new_participant)
+            )
+        db.session.add(hacknight)
+        db.session.commit()
+
+        hacknight_schema = HacknightSchema()
+        return {"hacknight": hacknight_schema.dump(hacknight)}, \
+            HTTPStatus.OK

backend/serializers/participant_serializer.py

@@ -4,10 +4,12 @@
 class ParticipantSchema(Schema):
     class Meta:
         fields = (
-            'id', 'name', 'lastname', 'email', 'github', 'hacknights', 'phone'
+            'id', 'participants_ids', 'name', 'lastname',
+            'email', 'github', 'hacknights', 'phone'
         )
         dump_only = ('id', 'hacknights')
 
+    participants_ids = fields.List(fields.Int())
     name = fields.Str(required=True, validate=[validate.Length(max=50)])
     lastname = fields.Str(validate=[validate.Length(max=50)])
     email = fields.Email(validate=[validate.Length(max=200)])

backend/tests/test_hacknight.py

@@ -1,4 +1,7 @@
 from http import HTTPStatus
+import json
+
+from backend.models import Hacknight, Participant
 
 
 def test_get_hacknights_when_logged_in(
@@ -31,3 +34,79 @@ def test_get_hacknights_unauthorized(client, add_hacknights):
     response = rv.get_json()
     assert rv.status_code == HTTPStatus.UNAUTHORIZED
     assert response['msg'] == 'Missing Authorization Header'
+
+
+def test_add_participants_to_hacknight(
+    access_token, add_hacknights, add_participants, client
+):
+    """Test add new participant to hacknight."""
+    payload = {'participants_ids': [1, 3]}
+    rv = client.patch(
+        '/hacknights/1/',
+        headers={'Authorization': 'Bearer {}'.format(access_token)},
+        data=json.dumps(payload)
+    )
+    resp = rv.get_json()
+    assert rv.status_code == HTTPStatus.OK
+
+    hacknight_db = Hacknight.query.get(1)
+    ids_from_db = [participant.id for participant in hacknight_db.participants]
+    for participant in resp['hacknight']['participants']:
+        assert participant['id'] in payload['participants_ids']
+    assert ids_from_db == payload['participants_ids']
+
+
+def test_add_participants_to_hacknight_unauthorized(
+    add_hacknights, add_participants, client
+):
+    """Test add participants to hacknight when user is not logged in."""
+    payload = {'participants_ids': [1, 3]}
+    rv = client.patch('/hacknights/1/', data=json.dumps(payload))
+    response = rv.get_json()
+    assert rv.status_code == HTTPStatus.UNAUTHORIZED
+    assert response['msg'] == 'Missing Authorization Header'
+
+
+def test_add_nonexisting_participants_to_hacknight(
+    access_token, add_hacknights, client
+):
+    """Test add non-existing participants ids to hacknight."""
+    payload = {'participants_ids': [1, 3]}
+    rv = client.patch(
+        '/hacknights/1/',
+        headers={'Authorization': 'Bearer {}'.format(access_token)},
+        data=json.dumps(payload)
+    )
+    assert rv.status_code == HTTPStatus.NOT_FOUND
+
+
+def test_add_participants_to_nonexisting_hacknight(
+    access_token, add_participants, client
+):
+    """Test add participants to non-existing hacknight."""
+    payload = {'participants_ids': [1, 3]}
+    rv = client.patch(
+        '/hacknights/1/',
+        headers={'Authorization': 'Bearer {}'.format(access_token)},
+        data=json.dumps(payload)
+    )
+    assert rv.status_code == HTTPStatus.NOT_FOUND
+
+
+def test_duplicate_participant_in_hacknight(
+    access_token, add_hacknights, add_participants, client, _db
+):
+    """Test add participant who is already in hacknight."""
+    hacknight = _db.session.query(Hacknight).first()
+    participant = _db.session.query(Participant).first()
+    hacknight.participants.append(participant)
+
+    payload = {'participants_ids': [participant.id]}
+    rv = client.patch(
+        '/hacknights/{}/'.format(hacknight.id),
+        headers={'Authorization': 'Bearer {}'.format(access_token)},
+        data=json.dumps(payload)
+    )
+    response = rv.get_json()
+    assert rv.status_code == HTTPStatus.BAD_REQUEST
+    assert response['message'] == 'No new participant has been provided'