Tests for get participants endpoint (fixes #104) #105
Conversation
| headers={'Authorization': 'Bearer {}'.format(access_token)} | ||
| ) | ||
| response = rv.get_json() | ||
| assert rv.status == "404 NOT FOUND" |
There was a problem hiding this comment.
Shouldn't that be 200 with 0 participants?
There was a problem hiding this comment.
In my opinion there should not occur a situation where there are 0 participants.
At the very beginning all Code of Poznań users should be added as participant and participants_list should return all of them.
There was a problem hiding this comment.
If you can do something with the application, someone will do that. ;-)
There was a problem hiding this comment.
It should be 200 OK here. That's a bug in the application and I created a separate issue to solve that: #130
backend/tests/conftest.py
Outdated
|
|
||
| @pytest.fixture | ||
| def add_participants(app, _db): | ||
| db = _db |
There was a problem hiding this comment.
Do not see a lot of reason for such assignment. Would say I'm fine with overwriting that symbol (just as def add_participants(app, db) or calling it at the end as _db.session.commit().
| @@ -0,0 +1,35 @@ | |||
| import pytest | |||
| headers={'Authorization': 'Bearer {}'.format(access_token)} | ||
| ) | ||
| response = rv.get_json() | ||
| assert rv.status == "200 OK" |
There was a problem hiding this comment.
I would check rv.status_code == HTTPStatus.200_OK
frontend/yarn.lock
Outdated
| version "1.4.0" | ||
| resolved "https://registry.yarnpkg.com/vuetify/-/vuetify-1.4.0.tgz#ad5446a319cf4b090d3e14f9c3ee2ac53d545415" | ||
| integrity sha512-Q6b5VrkGIhPTN+r/uw6P5UTYVQy0h3d4vRW5363qHTgzQfyYQk8BDlJNCTJj0Zu/z3aBq79zbyF88jbLlV9vxQ== | ||
| [email protected]: |
There was a problem hiding this comment.
change unconnected with a pull request.
magul
changed the title
No description provided.