Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ruler look more like Xcode by creating custom font. Make ruler font and ruler Inset scale with text font size. #170

Merged
merged 4 commits into from
Mar 26, 2023

Conversation

Eliulm
Copy link
Contributor

@Eliulm Eliulm commented Mar 26, 2023

Description

This PR adds a customized SF Pro Font which aims to look like the Xcode Digits font.
The ruler font and the ruler insets scale with the text font size.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

PointSize 13:
Xcode left, CodeEdit Right:
image

PointSize 20:
Xcode left, CodeEdit Right:
image

Sorry, something went wrong.

Eliulm added 3 commits March 26, 2023 20:56

Verified

This commit was signed with the committer’s verified signature.
Eliulm Elias Wahl
… and Ruler insets scale with font size. Bumped the minimum platform version to 13.

Verified

This commit was signed with the committer’s verified signature.
Eliulm Elias Wahl

Verified

This commit was signed with the committer’s verified signature.
Eliulm Elias Wahl
austincondiff
austincondiff previously approved these changes Mar 26, 2023
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just fix that comment typo

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Lukas Pistrol <[email protected]>
Copy link
Member

@lukepistrol lukepistrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Scale line numbers relative to font size 🐞 Line number font is incorrect
3 participants