Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated appendingPathComponent calls #1998

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Replace deprecated appendingPathComponent calls #1998

merged 1 commit into from
Feb 28, 2025
+67 −67

Conversation

FastestMolasses
Copy link
Member

Description

The appendingPathComponent function is deprecated and was replaced with just the appending(path: ) function.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@FastestMolasses FastestMolasses self-assigned this Feb 25, 2025
@austincondiff
Copy link
Collaborator

@FastestMolasses Fix tests but otherwise looks good!

thecoolwinter
thecoolwinter approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passing. Looks like it was a flaking UI test

@thecoolwinter thecoolwinter merged commit 50ba7d1 into main Feb 28, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the fix-path-deprecated branch February 28, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@thecoolwinter thecoolwinter thecoolwinter approved these changes

Assignees

@FastestMolasses FastestMolasses

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FastestMolasses @austincondiff @thecoolwinter