Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar scrolls with the list closes #1818 #1855

Conversation

scaredcr6w
Copy link
Contributor

Description

The search bar in the SettingsView is now on a different List that has no contents, the only purpose is to contain the search bar. Now it functions like the macOS System Settings search bar

Related Issues

Search bar scrolls with the list closes #1818

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Kepernyofelvetel.2024-08-21.-.15.55.04.mov

@austincondiff
Copy link
Collaborator

Could we add a divider line that fades in as you scroll as shown? If not we can do this in a follow up PR.

Screen.Recording.2024-08-21.at.12.14.28.PM.mov

@scaredcr6w
Copy link
Contributor Author

Couldn't hack it with the line, will do in a follow up.

@thecoolwinter
Copy link
Collaborator

Sounds good

@austincondiff austincondiff merged commit c516e7c into CodeEditApp:main Aug 23, 2024
2 checks passed
@thecoolwinter
Copy link
Collaborator

@allcontributors please add @scaredcr6w for code

Copy link
Contributor

@thecoolwinter

I've put up a pull request to add @scaredcr6w! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Search Bar scrolls With the List
3 participants