FIX: Git History Date bug

[tom-ludwig]

• Correct date isn't displayed in this history tab

• Branch image was slightly to big, compared to Xcode

• Branch menu color was a bit off

• Branch menu indicator wasn't hidden

Description

The commit date in the history tab wasn't displayed correctly. Additionally, the git branch menu had a few issues, including discrepancies in color, indicator visibility, and branch symbol size.

Related Issues

na

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

Before:

Now:

Before:

Now:

When hovering:

[tom-ludwig]

Could you please check which line works better in GitClient+CommitHistory.swift:

dateFormatter.locale = Locale(identifier: Locale.current.identifier)

or:

dateFormatter.locale = Locale(identifier: "en_US_POSIX")

Both should work.

[thecoolwinter]

Actually I have no issues with just Locale.current there, is that the problem? I'm fairly certain Locale(identifier: Locale.current.identifier) would resolve to the same thing.

[tom-ludwig]

It seems like Locale.current behaves differently outside the US. I tested all three options on my machine, and only using Locale.current resulted in a nil date. Austin had no issues with any option when testing the same code. Both approaches work for me, but I prefer Locale(identifier: Locale.current.identifier).

dateFormatter.locale = Locale(identifier: Locale.current.identifier)
dateFormatter.locale = Locale(identifier: "en_US_POSIX")

If you're okay with using Locale(identifier: Locale.current.identifier), we can just stick with that.

[thecoolwinter]

Okay! Yeah let's go with that, seems better than a hardcoded value.