Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update To New Text View #1509

Merged

Conversation

thecoolwinter
Copy link
Collaborator

Description

  • Updates CodeEditTextView to the new CodeEditSourceEditor repository, which includes a new text view.
  • Drastically improves performance when opening and editing files (128ms opening time for sqlite3.c, fast editing no matter how large the file).
  • Fixes stuttering when scrolling through files.
  • Implements a new gutter view.
  • Adds ability to open a file at either a line/column or at a selection range, and supports multiple cursors (related: ✨ Clicking Project Find result should place cursor in correct location #1504).
  • Improves support for multiple-cursors.
  • Adds a new API for managing, updating, and listening to editor text. In the future this should be used to update text for instance if the file's contents change.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Fast scrolling, editing, loading of any size file. Files used are: (sqlite3.c 150k LOC, and the Russian/English dictionary 15MB)

Screen.Recording.2023-12-13.at.1.13.41.PM.mov

Opening a file from the command line opens to the correct line/column. Even updating an already opened file to the new cursor location.

Screen.Recording.2023-12-13.at.1.17.58.PM.mov

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just had one comment.

I am so happy to see this PR (as I am sure you are as well). You've really outdone yourself with this one, very impressive! 👏

CodeEdit/Features/CodeFile/CodeFile.swift Show resolved Hide resolved
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoolwinter thecoolwinter merged commit e24f5af into CodeEditApp:main Dec 13, 2023
2 checks passed
@thecoolwinter thecoolwinter added the enhancement New feature or request label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants