Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dim editors without focus #1423

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Dim editors without focus #1423

merged 2 commits into from
Sep 20, 2023

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Sep 18, 2023 •
edited
Loading

Description

Provide users the option to dim editors without focus.
This adds a setting to toggle this functionality on or off (defaults to off).
Adds a View menu item to toggle editor dimming.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2023-09-18.at.6.28.39.PM.mp4

thecoolwinter
thecoolwinter previously approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast

bombardier200
bombardier200 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@bombardier200 bombardier200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast haha!

@austincondiff austincondiff merged commit a595143 into CodeEditApp:main Sep 20, 2023
@thecoolwinter thecoolwinter added the enhancement New feature or request label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@bombardier200 bombardier200 bombardier200 approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@Wouter01 Wouter01 Awaiting requested review from Wouter01

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Dim Editors Without Focus
3 participants
@austincondiff @bombardier200 @thecoolwinter