vsock: Dup() socket in newVirtioSocketConnection() #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already done in the SetSocketListenerForPort case, but it's also needed in the
ConnectToPort case.
Without this, the connection gets closed immediately when the host tries
to initiate a vsock connection to the guest (for example with `nc
--listen --vsock 2 1024` running on the guest).
This error is returned whne trying to connect:
```
2022/09/23 15:09:49 tcpproxy: for incoming conn , error dialing "vsock:1024": Error Domain=NSPOSIXErrorDomain Code=54 Description="The operation couldn’t be completed. Connection reset by peer" UserInfo={
}
```
The dup/dupCh types are now badly named as they no longer contain VirtioSocketConnections to run through Dup(). VirtioSocketConnection.dup() is no longer needed.
|
I'm not sure what is problem. I don't know how to reproduce the errors. |
Repository owner
locked as resolved and limited conversation to collaborators
Sep 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying socket for VirtioSocketConnection() is currently Dup()
when NewVirtioSocketListener() is used, but not when ConnectToPort() is used.
This prevents usage of ConnecToPort() from working properly, the connection is
closed too early.
This commit moves the Dup() to newVirtioSocketConnection() so that both
codepaths benefit from it.