Allow to use github.com/Code-Hex/vz/v2 from macOS 11/macOS 10 #48

cfergeau · 2022-09-12T13:26:53Z

This PR adds version annotation to the objective C API so that it's possible to
build vz/use it on a macOS 10/11 machine even if it does not implement all the
latest virtualization.framework API. When trying to use unsupported API,
vz.ErrUnsupportedOSVersion will be returned.

This addresses #41 as this
allows to support macOS 10, macOS 11 and macOS 12 in the same build.

cfergeau · 2022-09-12T13:36:53Z

I forgot to mention that after these changes there is still these warnings when building:

$ make
go build -o virtualization .
# github.com/Code-Hex/vz/v2
virtualization_view.m:170:5: warning: 'VZVirtualMachineView' is only available on macOS 12.0 or newer [-Wunguarded-availability-new]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtualMachineView.h:23:12: note: 'VZVirtualMachineView' has been marked as being introduced in macOS 12.0 here, but the deployment target is macOS 11.0.0
../../virtualization_view.h:25:12: note: annotate 'AppDelegate' with an availability attribute to silence this warning
virtualization_view.m:184:5: warning: 'VZVirtualMachineView' is only available on macOS 12.0 or newer [-Wunguarded-availability-new]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtualMachineView.h:23:12: note: 'VZVirtualMachineView' has been marked as being introduced in macOS 12.0 here, but the deployment target is macOS 11.0.0
virtualization_view.m:184:5: note: enclose 'VZVirtualMachineView' in an @available check to silence this warning
virtualization_view.m:184:37: warning: 'VZVirtualMachineView' is only available on macOS 12.0 or newer [-Wunguarded-availability-new]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtualMachineView.h:23:12: note: 'VZVirtualMachineView' has been marked as being introduced in macOS 12.0 here, but the deployment target is macOS 11.0.0
virtualization_view.m:184:37: note: enclose 'VZVirtualMachineView' in an @available check to silence this warning
codesign --entitlements vz.entitlements -s - ./virtualization
./virtualization: is already signed
make: *** [codesign] Error 1

I'd need help to silence them as I don't really manage to read the related objC code :(

audio.go

Code-Hex · 2022-09-18T09:48:17Z

@cfergeau Thanks!
Could you rebase some commit logs? and please fix it also for 11.0 APIs similar to your fixes. Thanks

Code-Hex · 2022-09-18T09:49:14Z

Please discard this commit
2b0ec58

cfergeau · 2022-09-19T10:49:37Z

Please discard this commit 2b0ec58

Apologies for this, I pushed some commits by mistake, the PR should have stopped at stop/canStop: Return errors from go API. It's now removed together with a few more commits.

cfergeau · 2022-09-19T10:55:49Z

please fix it also for 11.0 APIs similar to your fixes.

This was the plan after checking with this PR that the approach I took is acceptable, I'll work on it now!

Could you rebase some commit logs?

What commit logs do I need to rebase? I removed some of the commits I added by mistake, do you want more changes on logs of the existing commits?

Code-Hex · 2022-09-19T14:59:55Z

@cfergeau It's ok. Please continue.

Please write some test code. Thank you!

cfergeau · 2022-09-21T15:45:32Z

I've added some test to this series. It's still macos11 only, macos10 is progressing well in https://github.com/cfergeau/vz/tree/macos10, it's missing:

commit logs
tests

Tests are slightly more complicated, as the test must be built on macOS11 (no Virtualization.h header on macOS10 machines), and then run on macOS10. I haven't looked yet into doing that in github actions. I can't manually test as I no longer have a macOS10 machine.

cfergeau · 2022-09-22T14:23:12Z

I've added macos 10 "support". I've also added some tests. The macos10 tests are not run automatically in gh actions

Code-Hex · 2022-09-23T14:52:23Z

@cfergeau Could you please remove the part about the test code once you have written it, because to be honest the test code you write is unfortunately not of mergeable quality?

cfergeau · 2022-09-23T14:56:35Z

@cfergeau Could you please remove the part about the test code once you have written it, because to be honest the test code you write is unfortunately not of mergeable quality?

You asked about adding tests ( #48 (comment) ) so I wrote them. They test if we get ErrUnsupportedOS when expected.
If you prefer, yes I can remove them, no problem. Is it only the tests which are not of mergeable quality? Or are there more issues I need to fix?

Code-Hex · 2022-09-23T14:59:12Z

@cfergeau A test to determine availability can be done by mocking the version information.

Revert the test code, actions settings, and makefile modifications

Code-Hex · 2022-09-23T15:27:09Z

virtualization.go

+	if len(osverArray) < 1 {
+		return 0
+	}


Please remove this handling because the result will be more than or equal 1
https://go.dev/play/p/BJBkxhG0-lQ

Code-Hex · 2022-09-23T15:33:05Z

virtualization.go

@@ -294,3 +348,23 @@ func (v *VirtualMachine) Stop(fn func(error)) {
 func (v *VirtualMachine) StartGraphicApplication(width, height float64) {
 	C.startVirtualMachineWindow(v.Ptr(), C.double(width), C.double(height))
 }
+


Please fix like this

var ( majorVersion int majorVersionOnce sync.Once ) // This can be replaced in the test code to enable mock. // It will not be changed in production. var fetchMajorVersion = func() { osver, err := syscall.Sysctl("kern.osproductversion") if err != nil { panic(err) } osverArray := strings.Split(osver, ".") major, err := strconv.Atoi(osverArray[0]) if err != nil { panic(err) } majorVersion = major } func macOSMajorVersion() int { majorVersionOnce.Do(fetchMajorVersion) return majorVersion }

Thanks for the suggestion, I will do this!

Latest push should be closer to what you want. I kept the build tags. If you prefer, I can set majorVersion at the beginning of each test.

Code-Hex · 2022-09-24T01:07:51Z

Why can't you do what I commented on?

Revert the test code, actions settings, and makefile modifications

cfergeau · 2022-09-26T07:31:00Z

Why can't you do what I commented on?

Revert the test code, actions settings, and makefile modifications

I've removed all of this in my latest push. I thought the addition of fetchMajorVersion was a way of making the tests acceptable.
To be honest, I much prefer to have sub-optimal tests. It is always good to have some form of test code. Then the tests can be fixed to your liking/removed later.

Code-Hex

Probably last requests 🙏

Code-Hex · 2022-09-26T13:52:31Z

shared_folder.go

+import (
+	"runtime"
+)


Suggested change

import (

"runtime"

)

import "runtime"

Code-Hex · 2022-09-26T13:52:58Z

virtualization.go

 	"unsafe"
 )

+var ErrUnsupportedOSVersion error = errors.New("unsupported macOS version")


Add document (comment)

virtualization.go

Code-Hex · 2022-09-26T14:05:51Z

virtualization.h

@@ -21,7 +21,7 @@ bool shouldAcceptNewConnectionHandler(void *listener, void *connection, void *so

 /* VZVirtioSocketListener */
 @interface VZVirtioSocketListenerDelegateImpl : NSObject <VZVirtioSocketListenerDelegate>
- (BOOL)listener:(VZVirtioSocketListener *)listener shouldAcceptNewConnection:(VZVirtioSocketConnection *)connection fromSocketDevice:(VZVirtioSocketDevice *)socketDevice;
+- (BOOL)listener:(void *)listener shouldAcceptNewConnection:(void *)connection fromSocketDevice:(void *)socketDevice;


Please do not do anything that is not related to the intent of this PR. Please revert.

Suggested change

- (BOOL)listener:(void *)listener shouldAcceptNewConnection:(void *)connection fromSocketDevice:(void *)socketDevice;

- (BOOL)listener:(VZVirtioSocketListener *)listener shouldAcceptNewConnection:(VZVirtioSocketConnection *)connection fromSocketDevice:(VZVirtioSocketDevice *)socketDevice;

This is indirectly related as this silences some warnings when building on older macOS versions. I've split the changes to a separate commit with an explanation.

I'm not sure what you mean. This library is supported only above macOS v11.0. So I think this is no problem.

#41 asks for macOS v10 'support'. There will be no virtualization on these platforms, but errors/exceptions will be returned. Returning errors/exceptions need to be done in Code-Hex/vz. To add these, I use a lot compiler warnings:

# github.com/Code-Hex/vz/v2 In file included from _cgo_export.c:4: In file included from socket.go:6: ../../virtualization.h:24:19: warning: 'VZVirtioSocketListener' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtioSocketListener.h:25:12: note: 'VZVirtioSocketListener' has been marked as being introduced in macOS 11.0 here, but the deployment target is macOS 10.13.0 ../../virtualization.h:24:1: note: annotate 'listener:shouldAcceptNewConnection:fromSocketDevice:' with an availability attribute to silence this warning ../../virtualization.h:24:80: warning: 'VZVirtioSocketConnection' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtioSocketConnection.h:18:12: note: 'VZVirtioSocketConnection' has been marked as being introduced in macOS 11.0 here, but the deployment target is macOS 10.13.0 ../../virtualization.h:24:1: note: annotate 'listener:shouldAcceptNewConnection:fromSocketDevice:' with an availability attribute to silence this warning ../../virtualization.h:24:136: warning: 'VZVirtioSocketDevice' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtioSocketDevice.h:25:12: note: 'VZVirtioSocketDevice' has been marked as being introduced in macOS 11.0 here, but the deployment target is macOS 10.13.0 ../../virtualization.h:24:1: note: annotate 'listener:shouldAcceptNewConnection:fromSocketDevice:' with an availability attribute to silence this warning

If there are warnings, there is some code without @available. If there are pages and pages of warnings, I will not notice new code missing @available. This is why I prefer to remove all the warnings I can.

My opinion. #41 (comment)

I don't support the compilation on macOS v10. because It depends on xcode sdk.
So you don't need to consider for v10.

These warnings happen with latest macOS/xcode when you build a binary for macOS 10 or newer:

% sw_vers ProductName: macOS ProductVersion: 12.6 BuildVersion: 21G115 % CGO_CFLAGS=-mmacosx-version-min=10.13 make -C example/linux go build -o virtualization . # github.com/Code-Hex/vz/v2 In file included from virtualization.m:8: ../../virtualization_view.h:26:41: warning: 'VZVirtualMachine' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtualMachine.h:67:12: note: 'VZVirtualMachine' has been marked as being introduced in macOS 11.0 here, but the deployment target is macOS 10.13.0 ../../virtualization_view.h:26:1: note: annotate 'initWithVirtualMachine:windowWidth:windowHeight:' with an availability attribute to silence this warning virtualization.m:1249:37: warning: 'VZVirtualMachine' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtualMachine.h:67:12: note: 'VZVirtualMachine' has been marked as being introduced in macOS 11.0 here, but the deployment target is macOS 10.13.0 virtualization.m:1249:37: note: enclose 'VZVirtualMachine' in an @available check to silence this warning # github.com/Code-Hex/vz/v2

They are not related to building on macOS 10. I agree we don't need to support building on macOS 10.

Please revert this~

@cfergeau Ping

Code-Hex · 2022-09-26T14:06:27Z

virtualization.m

@@ -36,9 +36,13 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N
 @end

 @implementation VZVirtioSocketListenerDelegateImpl
- (BOOL)listener:(VZVirtioSocketListener *)listener shouldAcceptNewConnection:(VZVirtioSocketConnection *)connection fromSocketDevice:(VZVirtioSocketDevice *)socketDevice;
+- (BOOL)listener:(void *)listener shouldAcceptNewConnection:(void *)connection fromSocketDevice:(void *)socketDevice;


Please do not do anything that is not related to the intent of this PR. Please revert.

Suggested change

- (BOOL)listener:(void *)listener shouldAcceptNewConnection:(void *)connection fromSocketDevice:(void *)socketDevice;

- (BOOL)listener:(VZVirtioSocketListener *)listener shouldAcceptNewConnection:(VZVirtioSocketConnection *)connection fromSocketDevice:(VZVirtioSocketDevice *)socketDevice;

Same reasons as #48 (comment)

Please revert this~

virtualization.m

Code-Hex · 2022-09-26T14:13:19Z

virtualization_arm64.h

@@ -65,7 +65,7 @@ void *newVZMacMachineIdentifierWithPath(const char *machineIdentifierPath);
 void *newVZMacMachineIdentifierWithBytes(void *machineIdentifierBytes, int len);
 nbyteslice getVZMacMachineIdentifierDataRepresentation(void *machineIdentifierPtr);

-VZMacOSRestoreImageStruct convertVZMacOSRestoreImage2Struct(VZMacOSRestoreImage *restoreImage);
+VZMacOSRestoreImageStruct convertVZMacOSRestoreImage2Struct(void *restoreImagePtr);


Please do not do anything that is not related to the intent of this PR. Please revert.

Suggested change

VZMacOSRestoreImageStruct convertVZMacOSRestoreImage2Struct(void *restoreImagePtr);

VZMacOSRestoreImageStruct convertVZMacOSRestoreImage2Struct(VZMacOSRestoreImage *restoreImagePtr);

This is also related to #48 (comment)

This code is used only internally. So I don't think this is no problem

Please revert this~

I still think we need this ( #48 (comment) ). It is really useful for the maintainance of macOS 11/macOS 10 compat code. If there are too many warnings, we will not notice the new ones.

It also makes the code consistent with the other convert* functions:

virtualization.h:VZVirtioSocketConnectionFlat convertVZVirtioSocketConnection2Flat(void *connection); virtualization_arm64.h:VZMacOSConfigurationRequirementsStruct convertVZMacOSConfigurationRequirements2Struct(void *requirementsPtr); virtualization_arm64.h:VZMacHardwareModelStruct convertVZMacHardwareModel2Struct(void *hardwareModelPtr);

They all use void*

@cfergeau Ping
(Because I don't need to support os 10)

This specific change is about macOS11. Commit log mentions CGO_CFLAGS=-mmacosx-version-min=11.0 and warning: 'VZMacOSRestoreImage' is only available on macOS 12.0 or newer.

I've reverted the vsock one (to avoid force push). I'd like to squash all the latest changes/remove the problematic commit and then force-push though as it's getting messy ^^.

This function is used only internally not in the Go world. So I want to revert this one (because this is not following other convert function rules).
I think we can remove it from the header file.

This is why I don't want to do code reviews.

I'd like to squash all the latest changes/remove the problematic commit and then force-push though as it's getting messy ^^.

This function is used only internally not in the Go world.

I know it is only internal. But the objc compiler warns about it.

(because this is not following other convert function rules).

All other convert functions are using void *:

vz/virtualization.h

Line 124 in 37646e1

VZVirtioSocketConnectionFlat convertVZVirtioSocketConnection2Flat(void *connection);

vz/virtualization_arm64.h

Lines 72 to 73 in 37646e1

VZMacOSConfigurationRequirementsStruct convertVZMacOSConfigurationRequirements2Struct(void *requirementsPtr);

VZMacHardwareModelStruct convertVZMacHardwareModel2Struct(void *hardwareModelPtr);

convertVZMacOSRestoreImage2Struct is the only one using VZMacOSRestoreImage * and not void *. This change makes all convert functions the same. And it removes a compilation warning. This will be useful for future maintainance.

Warning with CGO_CFLAGS=-mmacosx-version-min=11.0 is still present even if I remove convertVZMacOSRestoreImage2Struct from the header

# github.com/Code-Hex/vz/v2 virtualization_arm64.m:330:68: warning: 'VZMacOSRestoreImage' is only available on macOS 12.0 or newer [-Wunguarded-availability-new] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZMacOSRestoreImage.h:30:12: note: 'VZMacOSRestoreImage' has been marked as being introduced in macOS 12.0 here, but the deployment target is macOS 11.0.0 virtualization_arm64.m:330:34: note: annotate 'convertVZMacOSRestoreImage2Struct' with an availability attribute to silence this warning

cfergeau · 2022-09-28T11:22:12Z

In the latest iteration, I've added exceptions. I wrote the code as described in #48 (comment)

void setDirectorySharingDevicesVZVirtualMachineConfiguration(void *config, void *directorySharingDevices)
{
    if (@available(macOS 12, *)) {
        [(VZVirtualMachineConfiguration *)config setDirectorySharingDevices:[(NSMutableArray *)directorySharingDevices copy]];
    }  else {
        [[NSException exceptionWithName:@"UnhandledException" reason:@"bug" userInfo:nil] raise]; \
    }
}

It is important to write it this way to avoid compiler warnings. The compiler warnings will be useful when new code is added. They will tell us about APIs which require to be wrapped in @available.

virtualization_arm64.m

@available

This adds @available(macOS 11, *) annotations to the classes related to virtual machine configguration to indicate virtualization framework is only available in macOS 11+ The corresponding go NewXXX methods return ErrUnsupportedOSVersion when running on macOS 10 systems.

@available

This adds @available(macOS 11, *) annotations to the classes related to virtio-rng to indicate virtualization framework is only available in macOS 11+ The corresponding go NewXXX methods return ErrUnsupportedOSVersion when running on macOS 10 systems.

@available

This adds @available(macOS 11, *) annotations to the classes related to virtio-balloon to indicate virtualization framework is only available in macOS 11+ The corresponding go NewXXX methods return ErrUnsupportedOSVersion when running on macOS 10 systems.

@available

This adds @available(macOS 11, *) annotations to the classes related to virtio-net to indicate virtualization framework is only available in macOS 11+ The corresponding go NewXXX methods return ErrUnsupportedOSVersion when running on macOS 10 systems.

@available

This adds @available(macOS 11, *) annotations to the classes related to virtio-serial to indicate virtualization framework is only available in macOS 11+ The corresponding go NewXXX methods return ErrUnsupportedOSVersion when running on macOS 10 systems.

@available

This adds @available(macOS 11, *) annotations to the classes related to virtio-blk to indicate virtualization framework is only available in macOS 11+ The corresponding go NewXXX methods return ErrUnsupportedOSVersion when running on macOS 10 systems.

@available

This adds @available(macOS 11, *) annotations to the classes related to VM handling to indicate virtualization framework is only available in macOS 11+ The corresponding go NewXXX methods return ErrUnsupportedOSVersion when running on macOS 10 systems.

@available

This adds @available(macOS 11, *) annotations to the classes related to virtio-vsock to indicate virtualization framework is only available in macOS 11+ The corresponding go NewXXX methods return ErrUnsupportedOSVersion when running on macOS 10 systems.

shouldAcceptNewConnection currently has VZVirtioSocketListener *, VZVirtioSocketConnection * and VZVirtioSocketDevice * parameters, which cause the warning below when trying to build for an older version of macOS with CGO_CFLAGS=-mmacosx-version-min=10.13. This commit changes these types to `void *` to silence this warning: # github.com/Code-Hex/vz/v2 In file included from _cgo_export.c:4: In file included from socket.go:6: ../../virtualization.h:24:19: warning: 'VZVirtioSocketListener' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtioSocketListener.h:25:12: note: 'VZVirtioSocketListener' has been marked as being introduced in macOS 11.0 here, but the deployment target is macOS 10.13.0 ../../virtualization.h:24:1: note: annotate 'listener:shouldAcceptNewConnection:fromSocketDevice:' with an availability attribute to silence this warning ../../virtualization.h:24:80: warning: 'VZVirtioSocketConnection' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtioSocketConnection.h:18:12: note: 'VZVirtioSocketConnection' has been marked as being introduced in macOS 11.0 here, but the deployment target is macOS 10.13.0 ../../virtualization.h:24:1: note: annotate 'listener:shouldAcceptNewConnection:fromSocketDevice:' with an availability attribute to silence this warning ../../virtualization.h:24:136: warning: 'VZVirtioSocketDevice' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtioSocketDevice.h:25:12: note: 'VZVirtioSocketDevice' has been marked as being introduced in macOS 11.0 here, but the deployment target is macOS 10.13.0 ../../virtualization.h:24:1: note: annotate 'listener:shouldAcceptNewConnection:fromSocketDevice:' with an availability attribute to silence this warning

Code-Hex · 2022-10-04T01:20:25Z

@cfergeau If you force push, I can't check what's been fixed, so please don't do from next.

Code-Hex · 2022-10-04T01:25:28Z

example/linux/main.go

 		vmlinuz,
 		vz.WithCommandLine(strings.Join(kernelCommandLineArguments, " ")),
 		vz.WithInitrd(initrd),
 	)
+	if err != nil {
+		panic(err)


Could you replace panic with log.Fatal(err)?
I used panic because it does not complete the setup for logger in line 41.

cfergeau · 2022-10-04T08:37:10Z

@cfergeau If you force push, I can't check what's been fixed, so please don't do from next.

Ah yes, github is annoying, it does not keep old versions of PRs :(
I added fixup commits to this new iteration, they can be squashed before it's merged.

Code-Hex · 2022-10-05T02:24:43Z

@cfergeau Thank you!

This reverts commit f3fdf30.

cfergeau force-pushed the macos11 branch from 5280fc4 to c6f7f2c Compare September 14, 2022 14:06

Code-Hex reviewed Sep 18, 2022

View reviewed changes

audio.go Outdated Show resolved Hide resolved

cfergeau force-pushed the macos11 branch from c6f7f2c to bb5206e Compare September 19, 2022 10:48

cfergeau force-pushed the macos11 branch from bb5206e to b158d63 Compare September 21, 2022 15:41

cfergeau force-pushed the macos11 branch 2 times, most recently from 1bbc1fc to 18b71ff Compare September 22, 2022 14:21

cfergeau force-pushed the macos11 branch from 18b71ff to 5b190e4 Compare September 22, 2022 14:52

cfergeau mentioned this pull request Sep 23, 2022

Support building in older version of macOS #41

Closed

cfergeau changed the title ~~Allow to use github.com/Code-Hex/vz/v2 from macOS 11~~ Allow to use github.com/Code-Hex/vz/v2 from macOS 11/macOS 10 Sep 23, 2022

Code-Hex requested changes Sep 23, 2022

View reviewed changes

cfergeau force-pushed the macos11 branch from 5b190e4 to a6e116b Compare September 23, 2022 16:19

cfergeau force-pushed the macos11 branch from a6e116b to 6fdbc8c Compare September 26, 2022 07:27

Code-Hex requested changes Sep 26, 2022

View reviewed changes

cfergeau force-pushed the macos11 branch from 6fdbc8c to 9bfb996 Compare September 28, 2022 11:19

Code-Hex reviewed Sep 30, 2022

View reviewed changes

virtualization_arm64.m Outdated Show resolved Hide resolved

Code-Hex reviewed Sep 30, 2022

View reviewed changes

virtualization_arm64.m Outdated Show resolved Hide resolved

cfergeau added 9 commits October 3, 2022 14:20

vm: Add @available annotations

3a998ab

This adds @available(macOS 11, *) annotations to the classes related to VM handling to indicate virtualization framework is only available in macOS 11+ The corresponding go NewXXX methods return ErrUnsupportedOSVersion when running on macOS 10 systems.

cfergeau force-pushed the macos11 branch 2 times, most recently from bbedaa5 to f3fdf30 Compare October 3, 2022 12:27

Code-Hex reviewed Oct 4, 2022

View reviewed changes

cfergeau added 9 commits October 4, 2022 10:25

fixup! bootloader: Add @available annotations

75455ce

fixup! configuration: Add @available annotations

2455a2b

fixup! serial: Add @available annotations

6b193e5

fixup! network: Add @available annotations

aa375a8

fixup! entropy: Add @available annotations

bf4c348

fixup! storage: Add @available annotations

350256d

fixup! balloon: Add @available annotations

8dcb094

fixup! vsock: Add @available annotations

f24f8d0

fixup! vm: Add @available annotations

6252dfc

cfergeau added 2 commits October 4, 2022 14:51

fixup! file sharing: Add @available annotations

cadcdf6

fixup! macos: Add @available annotations

3be83f7

Revert "vsock: Don't expose VZVirtio* in header"

1546d24

This reverts commit f3fdf30.

Code-Hex merged commit 1b0b4ea into Code-Hex:master Oct 8, 2022

Code-Hex mentioned this pull request Oct 8, 2022

Task for v3 #59

Closed

5 tasks

tricktron mentioned this pull request Jan 5, 2023

lima: 0.13.0 -> 0.14.2 NixOS/nixpkgs#206285

Merged

13 tasks

	- (BOOL)listener:(void )listener shouldAcceptNewConnection:(void )connection fromSocketDevice:(void *)socketDevice;
	- (BOOL)listener:(VZVirtioSocketListener )listener shouldAcceptNewConnection:(VZVirtioSocketConnection )connection fromSocketDevice:(VZVirtioSocketDevice *)socketDevice;

	VZMacOSRestoreImageStruct convertVZMacOSRestoreImage2Struct(void *restoreImagePtr);
	VZMacOSRestoreImageStruct convertVZMacOSRestoreImage2Struct(VZMacOSRestoreImage *restoreImagePtr);

	VZMacOSConfigurationRequirementsStruct convertVZMacOSConfigurationRequirements2Struct(void *requirementsPtr);
	VZMacHardwareModelStruct convertVZMacHardwareModel2Struct(void *hardwareModelPtr);

Allow to use github.com/Code-Hex/vz/v2 from macOS 11/macOS 10 #48

Allow to use github.com/Code-Hex/vz/v2 from macOS 11/macOS 10 #48

Conversation

cfergeau commented Sep 12, 2022 • edited Loading

cfergeau commented Sep 12, 2022

Code-Hex commented Sep 18, 2022

Code-Hex commented Sep 18, 2022

cfergeau commented Sep 19, 2022 • edited Loading

cfergeau commented Sep 19, 2022 • edited Loading

Code-Hex commented Sep 19, 2022

cfergeau commented Sep 21, 2022

cfergeau commented Sep 22, 2022

Code-Hex commented Sep 23, 2022

cfergeau commented Sep 23, 2022 • edited Loading

Code-Hex commented Sep 23, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Code-Hex commented Sep 24, 2022

cfergeau commented Sep 26, 2022

Code-Hex left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cfergeau Oct 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cfergeau Oct 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Code-Hex Oct 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cfergeau Oct 6, 2022 • edited Loading

Choose a reason for hiding this comment

cfergeau commented Sep 28, 2022

Code-Hex commented Oct 4, 2022

Choose a reason for hiding this comment

cfergeau commented Oct 4, 2022

Code-Hex commented Oct 5, 2022

cfergeau commented Sep 12, 2022 •

edited

Loading

cfergeau commented Sep 19, 2022 •

edited

Loading

cfergeau commented Sep 19, 2022 •

edited

Loading

cfergeau commented Sep 23, 2022 •

edited

Loading

cfergeau Oct 3, 2022 •

edited

Loading

cfergeau Oct 4, 2022 •

edited

Loading

Code-Hex Oct 6, 2022 •

edited

Loading

cfergeau Oct 6, 2022 •

edited

Loading