Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set MSRV to 1.74 and enforce it in CI #52

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chore: set MSRV to 1.74 and enforce it in CI #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,20 @@ jobs:
with:
extra_args: --all-files

msrv-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: moonrepo/setup-rust@v1
with:
bins: cargo-msrv
- name: Check cospeed MSRV
run: cargo msrv --path crates/codspeed verify -- cargo check --all-features --config codspeed=true
- name: Check bencher_compat MSRV
run: cargo msrv --path crates/bencher_compat verify -- cargo check --all-features --config codspeed=true
- name: Check criterion_compat MSRV
run: cargo msrv --path crates/criterion_compat verify -- cargo check --all-features --config codspeed=true

tests:
runs-on: ubuntu-latest
steps:
Expand Down
20 changes: 10 additions & 10 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/bencher_compat/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[package]
name = "codspeed-bencher-compat"
version = "2.7.0"
rust-version = "1.74" # MSRV
edition = "2021"
description = "Bencher compatibility layer for CodSpeed"
authors = ["Arthur Pastel <[email protected]>"]
Expand Down
2 changes: 1 addition & 1 deletion crates/bencher_compat/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
fn main() {
println!("cargo::rustc-check-cfg=cfg(codspeed)");
println!("cargo:rustc-check-cfg=cfg(codspeed)");
}
1 change: 1 addition & 0 deletions crates/codspeed/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[package]
name = "codspeed"
version = "2.7.0"
rust-version = "1.74" # MSRV
edition = "2021"
description = "Core instrumentation library for CodSpeed"
authors = ["Arthur Pastel <[email protected]>"]
Expand Down
3 changes: 2 additions & 1 deletion crates/criterion_compat/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[package]
name = "codspeed-criterion-compat"
version = "2.7.0"
rust-version = "1.74" # MSRV
edition = "2021"
description = "Criterion.rs compatibility layer for CodSpeed"
authors = ["Arthur Pastel <[email protected]>"]
Expand All @@ -20,7 +21,7 @@ criterion = { version = "0.5.1", default-features = false }
codspeed = { path = "../codspeed", version = "=2.7.0" }
colored = "2.1.0"

futures = { version = "0.3", default_features = false, optional = true }
futures = { version = "0.3", default-features = false, optional = true }
smol = { version = "2.0", default-features = false, optional = true }
tokio = { version = "1.39", default-features = false, features = [
"rt",
Expand Down
2 changes: 1 addition & 1 deletion crates/criterion_compat/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
fn main() {
println!("cargo::rustc-check-cfg=cfg(codspeed)");
println!("cargo:rustc-check-cfg=cfg(codspeed)");
}
Loading