Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception set comment to match Xcode #1000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

walkingbrad
Copy link

When Xcode edits the project file, it reverts this specific (though helpful) comment to PBXFileSystemSynchronizedBuildFileExceptionSet.

So this prevents this line from continuing to get changed/reverted as we edit project files in both Xcode and xcodeproj

@walkingbrad
Copy link
Author

This might be a 16.0/1 issue only. Verifying in 16.2...

@sergiocampama
Copy link

sergiocampama commented Dec 13, 2024

This fixes CocoaPods/CocoaPods#12697 as this error happens when using the new automatic tracking folder groups in Xcode 16 and above.

@robnadin
Copy link

Any movement on this?

@reggian
Copy link

reggian commented Feb 13, 2025

It also happens on our project.

Along with the formatting back and forths:
Xcode 16.2 uses condensed format:

/* Begin PBXFileSystemSynchronizedRootGroup section */
		E12863882D59E53C00CA99E1 /* Sources */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (E12864172D59E53D00CA99E1 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, E12864182D59E53D00CA99E1 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = Sources; sourceTree = "<group>"; };
/* End PBXFileSystemSynchronizedRootGroup section */

Xcodeproj 1.27.0 uses petty printed:

/* Begin PBXFileSystemSynchronizedRootGroup section */
		E12863882D59E53C00CA99E1 /* Sources */ = {
			isa = PBXFileSystemSynchronizedRootGroup;
			exceptions = (
				E12864172D59E53D00CA99E1 /* Exceptions for "Sources" folder in "IntentsExtensionUI" target */,
				E12864182D59E53D00CA99E1 /* Exceptions for "Sources" folder in "WidgetExtension" target */,
			);
			explicitFileTypes = {
			};
			explicitFolders = (
			);
			path = Sources;
			sourceTree = "<group>";
		};
/* End PBXFileSystemSynchronizedRootGroup section */

@robnadin
Copy link

It also happens on our project.

Unfortunately this can only be fixed in one of CocoaPods' dependencies.

I've raised a PR to fix it here but it needs the attention of the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants