Add support for xcfilelist in script_phase DSL
#517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add |
|
Tests already covered by existing tests around |
dnkoutso
force-pushed
the
io_file_list_support
branch
2 times, most recently
from
4efef1b to
7c08f78
Compare
amorde
reviewed
Mar 6, 2019
spec/specification/linter_spec.rb
Outdated
| @@ -462,10 +462,11 @@ def result_should_include(*values) | |||
| result_should_include('script_phases', 'Missing required shell script phase options `script` in script phase `Hello World`.') | |||
| end | |||
|
|
|||
| it 'checks script phases include the required keys' do | |||
| it 'checks script phases does not include unknown keys' do | |||
There was a problem hiding this comment.
this seems like there should be two tests that:
- Ensure required keys are specified
- Ensure all keys that are provided are known/valid
There was a problem hiding this comment.
its already added above
dnkoutso
force-pushed
the
io_file_list_support
branch
from
7c08f78 to
ea0932a
Compare
dnkoutso
force-pushed
the
io_file_list_support
branch
from
ea0932a to
d44181a
Compare
dnkoutso
commented
Mar 6, 2019
| @@ -462,10 +462,11 @@ def result_should_include(*values) | |||
| result_should_include('script_phases', 'Missing required shell script phase options `script` in script phase `Hello World`.') | |||
| end | |||
|
|
|||
| it 'checks script phases include the required keys' do | |||
| it 'checks script phases that include unknown keys' do | |||
There was a problem hiding this comment.
the test was named the same way as the one above
There was a problem hiding this comment.
probably from copy-pasta
amorde
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for CocoaPods/CocoaPods#8585