This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
Fix Nokogiri Build #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream version of this gem has an issue wherein it will fail to build depending on how Xcode is configured. On my system, the only way to make it build is to use a patched version.
|
@alloy - yours |
|
Obviously the better solution would be to have a working nokogiri, but until that’s figured out this can be used as a stopgap solution 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream version of
nokogiricurrently has an issue wherein it will fail to build depending on how Xcode is configured. On my system, the only way to make it build is to use a patched version. See sparklemotion/nokogiri#1345 for details. (Please forgive my aggressive tone when I filed that issue; it was not one of my better moments.)After the changes in #62, #65, and this PR are applied,
rake bundle:buildcompletes successfully on my system with no errors.