Allow no badge count to be sent #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. @anachronistic? One thing that gives me pause is compatibility -- we need to work out a strategy for this and future breaking changes. One option is http://gopkg.in; another is to provide a gofmt script to automatically fix user code (see https://github.com/peterbourgon/g2s/blob/master/fix.bash) |
|
Going to abandon this and just maintain my own fork. |
This was referenced Jan 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes badge count a pointer to int which will allow for respecting of "omitempty" and no longer requires the zero hack. Now to get a badge count of zero you can explicitly set it to zero. Resolve #22