Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ch69] As a user, I can see Product Detail screen #6

Merged
merged 15 commits into from
Feb 9, 2021
Merged

[ch69] As a user, I can see Product Detail screen #6

merged 15 commits into from
Feb 9, 2021

Conversation

Raksani
Copy link
Member

@Raksani Raksani commented Jan 22, 2021 •
edited
Loading

https://app.clubhouse.io/cobda/story/69/as-a-user-i-can-see-product-detail-screen

Why?

This PR is the entry point for the Product Detail screen. And accessible by clicking Product Detail button which leads to Product List screen.

Changes

  • Create Product Detail screen.
  • Add Product Detail button in Product List screen which is redirecting to Product Detail screen.

Screenshot(s)

Before
Screenshot 2564-01-23 at 01 42 41
After
Product Detail screen was created.
Screenshot 2564-02-06 at 21 31 28
Product List is clickable to Product Detail page.
Screenshot 2564-02-06 at 21 31 15

@Raksani Raksani added the feature A new feature label Jan 22, 2021
@Raksani Raksani added this to the v0.1.0 milestone Jan 22, 2021
@Raksani Raksani self-assigned this Jan 22, 2021
@LilBank
Copy link
Collaborator

LilBank commented Jan 23, 2021

Please update PR description in Changes section.
Source: #4 (comment)

LilBank
LilBank requested changes Jan 23, 2021
View reviewed changes
Copy link
Collaborator

@LilBank LilBank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About package-lock.json, see here: #5 (review)

src/components/Search/styles.scss Outdated Show resolved Hide resolved
src/components/Search/index.tsx Outdated Show resolved Hide resolved
src/router/index.tsx Outdated Show resolved Hide resolved
src/screens/ProductList/styles.scss Outdated Show resolved Hide resolved
@Raksani Raksani changed the base branch from development to feature/product-list-ui January 23, 2021 13:25
@Raksani
Copy link
Member Author

Raksani commented Jan 23, 2021

About package-lock.json, see here: #5 (review)

There's no package-lock.json.

@Raksani Raksani force-pushed the feature/product-list-ui branch from 49e9fc0 to bb96621 Compare January 23, 2021 19:13
@Raksani Raksani force-pushed the feature/product-detail-ui branch 2 times, most recently from 813b6b7 to 40d37c8 Compare January 23, 2021 21:34
@Raksani Raksani force-pushed the feature/product-list-ui branch from bb96621 to 64b882b Compare January 25, 2021 17:24
@kimvcp kimvcp force-pushed the feature/product-list-ui branch from b7a7a16 to 29c7c01 Compare January 28, 2021 10:14
@LilBank LilBank force-pushed the feature/product-list-ui branch from c06a87b to 15ac8ed Compare January 29, 2021 07:49
@kimvcp kimvcp force-pushed the feature/product-list-ui branch from 15ac8ed to cec0d59 Compare January 29, 2021 09:32
@Raksani Raksani force-pushed the feature/product-list-ui branch from 7edcd05 to a7ded47 Compare January 31, 2021 09:04
@LilBank LilBank force-pushed the feature/product-list-ui branch from ef0a87f to b2fcd15 Compare February 1, 2021 04:17
@Raksani Raksani force-pushed the feature/product-list-ui branch 4 times, most recently from 3cd3fd8 to 965eacb Compare February 2, 2021 15:55
Base automatically changed from feature/product-list-ui to development February 2, 2021 17:23
@Raksani Raksani force-pushed the feature/product-detail-ui branch from 40d37c8 to f12230e Compare February 3, 2021 15:07
@Cobda Cobda deleted a comment from LilBank Feb 3, 2021
LilBank
LilBank requested changes Feb 4, 2021
View reviewed changes
src/components/ProductDetail/index.tsx Outdated Show resolved Hide resolved
src/components/ProductList/index.tsx Outdated Show resolved Hide resolved
src/components/ProductDetail/index.tsx Outdated Show resolved Hide resolved
@LilBank LilBank requested a review from jbrucker February 5, 2021 04:18
@kimvcp
Copy link
Member

kimvcp commented Feb 5, 2021 •
edited
Loading

  1. Please use Pascal case for naming all .tsx file except those under /pages which should be the Kebab case.
    Example here
  2. .scss files that are responsible for grid layout should be located under /layouts folder.

LilBank
LilBank requested changes Feb 5, 2021
View reviewed changes
src/components/ProductList/index.tsx Outdated Show resolved Hide resolved
src/components/ProductView/index.tsx Outdated Show resolved Hide resolved
src/components/ProductView/product-detail.tsx Outdated Show resolved Hide resolved
src/pages/product-detail.tsx Outdated Show resolved Hide resolved
src/styles/layouts/_layout-product-detail.scss Outdated Show resolved Hide resolved
kimvcp
kimvcp reviewed Feb 6, 2021
View reviewed changes
src/pages/product-view.tsx Outdated Show resolved Hide resolved
@Cobda Cobda deleted a comment from LilBank Feb 6, 2021
Raksani
Raksani commented Feb 6, 2021
View reviewed changes
src/components/ProductCard/index.tsx Show resolved Hide resolved
src/components/ProductContent/ProductMedia.tsx Show resolved Hide resolved
src/components/ProductList/index.tsx Show resolved Hide resolved
src/styles/components/_product-media.scss Outdated Show resolved Hide resolved
@LilBank LilBank merged commit 968e3fa into development Feb 9, 2021
@LilBank LilBank deleted the feature/product-detail-ui branch February 9, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimvcp kimvcp kimvcp approved these changes

@LilBank LilBank LilBank approved these changes

@Kittinske15 Kittinske15 Awaiting requested review from Kittinske15

@jbrucker jbrucker Awaiting requested review from jbrucker

Assignees

@Raksani Raksani

Labels
feature A new feature
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Raksani @LilBank @kimvcp @Kittinske15